From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 016A1C4332F for ; Sun, 20 Nov 2022 10:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=csz8uJ+NswB19HXQOG8NrZUg8h0M3B2PSTKbek4wKdI=; b=K9JYIBZZJgaN3b EIJbiUfdJxq2IgpIgFuRy8QO4mb26eAGnPW637lCKm6VHik5vF6P6mp5mmW/3YXr8D4oIRJBTPta7 H8aWyrajUz1gJtAytk7vhDAUnMUAWCdlA+AR4vyIHsxI3QKSFL7IUbAhs5mGdtv0CYLIlKBuvne01 JCX6y4+Ox9loV0+fIOZS92xZHZ1VIw3RNWnlwO2h9QFXYUBcF08GDwalBO4AviqzE/UGmGTLyeP3X iV+aeYKZj1f/5OwxbzQjHN6iJ8BJy9kRyAhr7rVniLuNnXbQarGA0X2BntwiOLv7whg1g5xM/GVhf 6cFO02z2vr+KYRu+mgDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1owhgj-003cNF-S4; Sun, 20 Nov 2022 10:36:38 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1owhgg-003cMQ-W9 for linux-arm-kernel@lists.infradead.org; Sun, 20 Nov 2022 10:36:36 +0000 Received: by mail-lf1-x136.google.com with SMTP id j4so14971624lfk.0 for ; Sun, 20 Nov 2022 02:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bkqr5CITlf9Pw0k+sezW0jUIFDxvpCmwSMWyehFOiNM=; b=l01VxSQh8yun766SjOSDe7zfb3SL3HFlZdKdnKf6D2EiEzXVI2Av+lmCp2NZ3lVlpi Y1vEvHZJw3wFXGX8mBTgR99tBrci4iwdycuAW/irJzmXCKEaLmEYE7tla4U219jYYgbu Ak71A+oY5nA0KSe2u+ozcIWsvG4O2ZWQUiXohw9BlFJCJFvsfSfm2aLpRJ2dQORoJodZ 4qb7oYyFiJcNAQpz4ahaM//QrbawwiBwlOtchNsCfw4bxU1aDWxicQcnRxjMPb6tfVKa lilYfjjOSydFNN055+AMwVyOy7UBFRTHzCkdQlVY+9eDKHuOYZ01pXXvoMEHytic9Ecg dzwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bkqr5CITlf9Pw0k+sezW0jUIFDxvpCmwSMWyehFOiNM=; b=CjlBPERrU/OtI4eeWroc73BMk8UqRllURU0iECOu2r7NRAR+nHJ1ReHjVV4oKP44Yt mCsW8xdF1kd4668X1i4bue0yO9CqLZNYnTWnlzw+t0Xy037gIvMk8DwK2SjJfFAur4ki /J9gCBvWlth7UUqYK6QALtSvOngxbLscf080jiDgq58iwlg/pbKzPakFE+Lyd8Ff6hkY lqImDDVB540Z+xmQ1HsB0+5q3rNLcxXPWNkyojb67OaFPny/vpWA1SEARe2JNnPodwE3 d7+NRNNZ1o7Wz3HnIg8mFXanDg53AdxzUBi+W8IMSbuDrDHY6Cpvu3q0zGwzu4EqFaEu nxgQ== X-Gm-Message-State: ANoB5pkZnugxX74k0JtBWQnJ5T28/azm+ZIfP4epsy7a+E856ClTXhLT /eCWIHwlc4uELKcHMEJsyrkdp6JdAi/KP42i X-Google-Smtp-Source: AA0mqf6Mn70Z7ivGYWkW2u7n1bmFEm8KUVOAgQ7UoY06kP3Jgu4IpvXfJfXjOWCewEwECTOGz+/xQQ== X-Received: by 2002:a05:6512:b8f:b0:4a2:3953:7e43 with SMTP id b15-20020a0565120b8f00b004a239537e43mr4517786lfv.229.1668940592846; Sun, 20 Nov 2022 02:36:32 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u21-20020a196a15000000b00498f871f33fsm1497394lfu.86.2022.11.20.02.36.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 02:36:32 -0800 (PST) Message-ID: <238f7bf8-578c-5bb4-9f00-50f36334c5cf@linaro.org> Date: Sun, 20 Nov 2022 11:36:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example Content-Language: en-US To: Paul Elder Cc: linux-media@vger.kernel.org, Laurent Pinchart , Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Helen Koike , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221118093931.1284465-1-paul.elder@ideasonboard.com> <20221118093931.1284465-3-paul.elder@ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221120_023635_067596_5DBE17E4 X-CRM114-Status: GOOD ( 20.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/11/2022 07:55, Paul Elder wrote: > On Fri, Nov 18, 2022 at 02:06:14PM +0100, Krzysztof Kozlowski wrote: >> On 18/11/2022 10:39, Paul Elder wrote: >>> From: Laurent Pinchart >>> >>> Add an example to the rockchip-isp1 DT binding that showcases usage of >>> the parallel input of the ISP, connected to the CSI-2 receiver internal >>> to the i.MX8MP. >>> >>> Signed-off-by: Laurent Pinchart >> >> Missing SoB. > > I don't quite understand. I see an SoB right there. Laurent did not sent it. Did you run checkpatch before sending? > >> >>> --- >>> .../bindings/media/rockchip-isp1.yaml | 72 +++++++++++++++++++ >>> 1 file changed, 72 insertions(+) >>> >> >> I don't know what do you demonstrate there... usage of endpoints? That's >> the only difference. Such usage is the same everywhere, nothing specific > > I guess...? Doesn't the same argument apply against the px30 example too > then? > >> to this example. You already have two examples, so I don't think this >> brings anything more. > > We do have usage of this in imx8mp.dtsi and overlays for the ISP, but > those patches haven't been sent/merged yet, so in the meantime I think > there is value in providing an example here for the imx8mp. The examples are not for demonstrating imx8mp or any other soc, but this one given binding. Changing compatibles and few properties is not a different example - from "exampleness" point of view it is very similar. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel