From: Judith Mendez <jm@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Bhavya Kapoor <b-kapoor@ti.com>
Subject: Re: [PATCH] arm64: dts: k3-am654-idk: Add Support for MCAN
Date: Wed, 21 Aug 2024 12:24:23 -0500 [thread overview]
Message-ID: <23ac28aa-cd6e-41e3-ba26-d0a4c02d12fa@ti.com> (raw)
In-Reply-To: <20240821110149.yk3da663fek2a4sy@attitude>
Hi Nishanth,
On 8/21/24 6:01 AM, Nishanth Menon wrote:
> On 14:34-20240820, Judith Mendez wrote:
> [...]
>
>> +&m_can1 {
>> + status = "okay";
>
> NAK!
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117
Will fix in v2, thanks.
~ Judith
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&mcu_mcan1_pins_default>;
>> + phys = <&transceiver2>;
prev parent reply other threads:[~2024-08-21 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 19:34 [PATCH] arm64: dts: k3-am654-idk: Add Support for MCAN Judith Mendez
2024-08-21 11:01 ` Nishanth Menon
2024-08-21 17:24 ` Judith Mendez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ac28aa-cd6e-41e3-ba26-d0a4c02d12fa@ti.com \
--to=jm@ti.com \
--cc=b-kapoor@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox