From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54455C3DA5D for ; Fri, 19 Jul 2024 14:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TqH5ThulB6eCstIaJDjWzKRXS5vnwShMKgFVDmGVb/0=; b=g41LT3KeUr5oXIuLiFKIrWfe7f KwtL0x6EtCB9o7SDO21zGI9Si9ow5iMj8VLip2sS+zfEhj+2LbSZDaADfLv6WGQQgQnryj1FZ4tt8 GEtb6uGi5sdaojN+EdFj+/QZQqywCKfjUY9ZWUGVYD4ZsSL6YxG9HwGflFlbEnFfHVJnMh46Wifja DXXJNSyx0/JfyXrTSpETi0WYiO8zgik7kRjtT+SqDj79OWibZvzIFYTXVSE5ge4bNCgd9Tur++2ds kMUknR7LMLcxTjnJCaW+I9Ow2YHujm/M9KcIxVkgYL+nf6kRLSnGll2RFUGmQozpZeK3KTycqNBFi Po6O1HEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUoD1-00000002rYO-2uXG; Fri, 19 Jul 2024 14:03:43 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUoCf-00000002rTx-1iiO for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2024 14:03:23 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46JBaV5K016778; Fri, 19 Jul 2024 14:03:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TqH5ThulB6eCstIaJDjWzKRXS5vnwShMKgFVDmGVb/0=; b=ICoQjZ8NUPNe5f4N mDclJekaKVgroQ6Qrz14tR/RiPaux8UsniApsvhjPgv7JIgOE9F3nmTn/OULJfGG tROYUtyvXbo6i3SwqP7LjknvrmAOIxSKke8R3CgTULJHuNGVlhEj6nu6BNlbHi1U O+XqJRNlDQk+GLDRmOXQ9zrjNf9KOdH3jfKWC30a8lbtuW/zP6H83FAlpWdIjSjF 9GXN9OLQbCIUv9B+QX46nh4tWwUYFP/6/V+8a6Htn3EBKf2+yeEJyTbYIORrXMy+ TqULB5t7J0ePUXXbk3zzykQQ5mE12qUJGnOrHPy1X3K9FINTdER6jh3THc+gkcB0 SVVhOA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40fe33hme0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jul 2024 14:03:14 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 46JE3D6F030286 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jul 2024 14:03:13 GMT Received: from [10.48.247.102] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 19 Jul 2024 07:03:13 -0700 Message-ID: <23bd2022-3c9d-4d9d-943b-7d58c9dabf81@quicinc.com> Date: Fri, 19 Jul 2024 07:03:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro Content-Language: en-US To: Arnd Bergmann , Russell King CC: , , References: <20240622-md-arm-arch-arm-probes-kprobes-v1-1-0832bd6e45db@quicinc.com> <3808c973-1315-420c-900d-122a73a34f9e@quicinc.com> <05cacd03-686a-4ede-b485-7f4781f69b99@app.fastmail.com> From: Jeff Johnson In-Reply-To: <05cacd03-686a-4ede-b485-7f4781f69b99@app.fastmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 0RWw6JnGzOaGyy_gip3MXxoTE7nIgdgC X-Proofpoint-GUID: 0RWw6JnGzOaGyy_gip3MXxoTE7nIgdgC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-19_06,2024-07-18_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407190106 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_070321_615496_DE72860C X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/19/2024 4:28 AM, Arnd Bergmann wrote: > On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote: >> On 6/22/2024 9:34 PM, Jeff Johnson wrote: >>> With ARCH=arm, make allmodconfig && make W=1 C=1 reports: >>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o >>> >>> Add the missing invocation of the MODULE_DESCRIPTION() macro. >>> >>> Signed-off-by: Jeff Johnson >>> --- >>> arch/arm/probes/kprobes/test-core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c >>> index 171c7076b89f..6e9041a76b8b 100644 >>> --- a/arch/arm/probes/kprobes/test-core.c >>> +++ b/arch/arm/probes/kprobes/test-core.c >>> @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void) >>> >>> module_init(run_all_tests) >>> module_exit(kprobe_test_exit) >>> +MODULE_DESCRIPTION("ARM kprobes test module"); >>> MODULE_LICENSE("GPL"); >>> >>> #else /* !MODULE */ >>> >>> --- >>> base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b >>> change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3 >> >> I don't see this in linux-next yet so following up to see if anything else is >> needed to get this merged. > > Hi Jeff, > > The arm tree uses a separate submission system for reviewed > patches to get into the tree, see > > https://www.arm.linux.org.uk/developer/patches/info.php > https://www.arm.linux.org.uk/developer/patches/section.php?section=0 Thanks for the pointer. Hard to keep track of these when submitting tree-wide! > I looked at this file as well during build testing > and ended up combining the change with a cleanup, > If you like, I can send my version instead, see below. Please send your version since it has additional cleanup. /jeff