From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70C68CA0EFA for ; Fri, 22 Aug 2025 02:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cp1mFCWwcTWQzzsUUmh88+YFkDBcq7Y5lQlba0VlHo0=; b=kyXGifLK/LasXg8S817igtiV62 avWw5A9VI9o2ihJHXrAOCFwA/Lhu1oBN7q+4ffPSIn8USZ+lFYLFD3h5FTfCJDp1eQl5qeclOlRgx iAd18aF4g3O4zs0ExnXZZ/TU50nrf9T90YxT/xcIWxlH8EiuB+RnccQLG2z4iB0Gl9MW6reXGUH1A YB1tYAPxJFjjgZ6dgEhrHKMmXb9l4BInoc6YVEtduyH//2nzKvVrRrf5UU29MXAgAvq0SqSp9O4+4 WPJ4Q2UyjJZHqCabVFKeHx/AhBXUR1yZnB5CeLRAXX6IWpMwzckM2dNwXceoeBLgIrylVxWXSCcxd +a+BFlJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1upHV8-00000001HIC-0xqY; Fri, 22 Aug 2025 02:27:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1upCOr-00000000bQG-2bue for linux-arm-kernel@lists.infradead.org; Thu, 21 Aug 2025 21:00:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755810044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Cp1mFCWwcTWQzzsUUmh88+YFkDBcq7Y5lQlba0VlHo0=; b=Ki8uPsk9nP5e4ZH0nVbbHhhttLPWNZl+WO5ANQ75cCBbjQXRqL93G3qLR431fC850vLbhe uJuO874uea8/lIaNSq7dVrz0o9IzOsU+gImzKFfySWB6oJnF3Q2u+wVKYgxc6J/iDDpXP8 vzth14VBvh1IRhc5ZMqDuxXxyplC2Ds= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-g03pYrm1MUWTFq-ThM6SFw-1; Thu, 21 Aug 2025 17:00:42 -0400 X-MC-Unique: g03pYrm1MUWTFq-ThM6SFw-1 X-Mimecast-MFC-AGG-ID: g03pYrm1MUWTFq-ThM6SFw_1755810041 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3b9d41bd50aso1014202f8f.0 for ; Thu, 21 Aug 2025 14:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755810041; x=1756414841; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cp1mFCWwcTWQzzsUUmh88+YFkDBcq7Y5lQlba0VlHo0=; b=FJXNJ8UgaKkpplq1RvNqVyEv5+EPImqnCa5IamtZDfPt+E2nuT+9DU3YHAzXKkGYe3 G0kgmP8x976n3/8MgE378rO+J9O8XKTFxJPbN3vohJDEzKMzH+RKA5XpXZZhwM/jTfB+ vIQCn4eQ1CI7bPchtq/Mr0L5oHI9Cx34pyRgMAhmkmrXG5Uk/glokoepT6y2IkDLsjnh E7RiZPOqO03ij8Saxuop1GYwXWjjJaLwdHTXNOEuvLKU++yj8SyNtXThQiwhxPbZ7n/x Ncu04nX0h3eDwOM3ec4bbaRbL/sEtx63XmFSWRsaz75fZqdCvyTFjON/VZbmn8/JAAXO orCA== X-Forwarded-Encrypted: i=1; AJvYcCVHgOET03UsJ7+VPDf2IEeNYYwr9B8xy3rhFpnlvTBP5qSJyZJvfKRhdgMRBnDz7zhh1lej0y9KgfqQi5z5E9A6@lists.infradead.org X-Gm-Message-State: AOJu0Ywu+sOZh6084y3aegKOgPZLqLs+mWq7N5XZ+4ZBK/e+XJFx2NFn R5BtRDegh5MaqZ1HsGE8+ElOxbi+3z4NVBK5M4AtfjS1fh4ACqguKcxJvW6EgyEifnVtmaz3+0n Xx1fCYSk2R6TaW5EqZuJezEgC7StBpBaqouq6U+yNqkXpI70xZYSxdgw2gYTXnAx+lbcGVEm3rF wR X-Gm-Gg: ASbGncsG1QKRI5OmmNT2U/uAJNw4/hvL8XI0egVsQxGiEys7BQa8rei6mRtl1jDDUod RLbFAwGXLgxLJ/xRBQtGoZiU1r2JRBTm9cI5t2oRKyug1WRCPeUW1dCWE4iSYaL7vLj/OlmT1WA LwfmsqOvi4+XKA38Rz1LpCXKmvjVc61n3zftlhvGaiZ9U+QTZ8ltq/Qez1brCx0mtVGZIKDV7Sc z4oDKheSvThx1H3y+mIMv9yQH0SRVtD+9kZpfunKvvkM4+bwzwDUvymPNuaafZp4amxVE/YQyPV bLmAgQIOA0wS3tuXHJPzqdqljsjbnv1xuK/BYquyh/fI3XIlRC5OgX1tcQlJFoDOmVWPRQWENL3 G4YTOcwou/Z4BKRU1orhYWuWulviR2E1XeKdGRfsyDrH044euGNWeoOwvcKikWg== X-Received: by 2002:a05:6000:200d:b0:3a5:2465:c0c8 with SMTP id ffacd0b85a97d-3c5daa27e6amr265204f8f.7.1755810041307; Thu, 21 Aug 2025 14:00:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7vpqV63aDfbj4LuprqMLqq42InG6u1nR+Dt/+ZPeyx1uRJcEanVY8H02OCG3yOg5OQPh6rw== X-Received: by 2002:a05:6000:200d:b0:3a5:2465:c0c8 with SMTP id ffacd0b85a97d-3c5daa27e6amr265173f8f.7.1755810040805; Thu, 21 Aug 2025 14:00:40 -0700 (PDT) Received: from ?IPV6:2003:d8:2f26:ba00:803:6ec5:9918:6fd? (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c4ccbf04fasm3476159f8f.7.2025.08.21.14.00.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 14:00:40 -0700 (PDT) Message-ID: <23c6e511-19b2-4662-acfc-18692c899a6c@redhat.com> Date: Thu, 21 Aug 2025 23:00:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 13/35] mm: simplify folio_page() and folio_page_idx() To: Zi Yan Cc: linux-kernel@vger.kernel.org, Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org References: <20250821200701.1329277-1-david@redhat.com> <20250821200701.1329277-14-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Tb6VA8jwA0kSi24TxVYmoeQ-aUa0mxJSHvfJ1nIv00E_1755810041 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250821_140045_741219_FBABDE72 X-CRM114-Status: GOOD ( 24.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.08.25 22:55, Zi Yan wrote: > On 21 Aug 2025, at 16:06, David Hildenbrand wrote: > >> Now that a single folio/compound page can no longer span memory sections >> in problematic kernel configurations, we can stop using nth_page(). >> >> While at it, turn both macros into static inline functions and add >> kernel doc for folio_page_idx(). >> >> Signed-off-by: David Hildenbrand >> --- >> include/linux/mm.h | 16 ++++++++++++++-- >> include/linux/page-flags.h | 5 ++++- >> 2 files changed, 18 insertions(+), 3 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 48a985e17ef4e..ef360b72cb05c 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -210,10 +210,8 @@ extern unsigned long sysctl_admin_reserve_kbytes; >> >> #if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP) >> #define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n)) >> -#define folio_page_idx(folio, p) (page_to_pfn(p) - folio_pfn(folio)) >> #else >> #define nth_page(page,n) ((page) + (n)) >> -#define folio_page_idx(folio, p) ((p) - &(folio)->page) >> #endif >> >> /* to align the pointer to the (next) page boundary */ >> @@ -225,6 +223,20 @@ extern unsigned long sysctl_admin_reserve_kbytes; >> /* test whether an address (unsigned long or pointer) is aligned to PAGE_SIZE */ >> #define PAGE_ALIGNED(addr) IS_ALIGNED((unsigned long)(addr), PAGE_SIZE) >> >> +/** >> + * folio_page_idx - Return the number of a page in a folio. >> + * @folio: The folio. >> + * @page: The folio page. >> + * >> + * This function expects that the page is actually part of the folio. >> + * The returned number is relative to the start of the folio. >> + */ >> +static inline unsigned long folio_page_idx(const struct folio *folio, >> + const struct page *page) >> +{ >> + return page - &folio->page; >> +} >> + >> static inline struct folio *lru_to_folio(struct list_head *head) >> { >> return list_entry((head)->prev, struct folio, lru); >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index d53a86e68c89b..080ad10c0defc 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -316,7 +316,10 @@ static __always_inline unsigned long _compound_head(const struct page *page) >> * check that the page number lies within @folio; the caller is presumed >> * to have a reference to the page. >> */ >> -#define folio_page(folio, n) nth_page(&(folio)->page, n) >> +static inline struct page *folio_page(struct folio *folio, unsigned long nr) >> +{ >> + return &folio->page + nr; >> +} > > Maybe s/nr/n/ or s/nr/nth/, since it returns the nth page within a folio. Yeah, it's even called "n" in the kernel docs ... > > Since you have added kernel doc for folio_page_idx(), it does not hurt > to have something similar for folio_page(). :) ... which we already have! (see above the macro) :) Thanks! -- Cheers David / dhildenb