From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25DD6C48BF6 for ; Mon, 26 Feb 2024 16:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fqpbrL3kmlDwcXOh89oBY4JILnd/9Adw/j/V3vI40CY=; b=XE8KeI5tEr1/5t VP0r+xXR9LNtWfo0mPI3rF4HAeqqLIKnJkeA7z6vh+JE8sJDb/uA6uXu9+N02xoj41abwtLTIuHYQ jbOUte+KXhXooCF59pyLjWByLDOS1sAB7D1brUQo7AyxkuxkVNrICDGyxlGOGHNEtI9WN1ryZMFTa WzZIZsXXzTkc3BLXD8HMRcPrA2v9LDKNPZQ+zuQ3rpDjOnbCPTljAlDA7S2f/ZRGZDuI923DEaJr7 Kd0tQ3Cfr2UUN7lkRMrn7nLhz+sc8SQEdiWPYCazM4CEWlCCn+BRaXXC7bUztS4U42jpxMciUUgc5 0r3bH6s4u1RoQzVuUBJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rediE-00000001ctb-2xPl; Mon, 26 Feb 2024 16:20:18 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rediC-00000001csA-0hLv for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 16:20:17 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id AE8F15C0096; Mon, 26 Feb 2024 11:20:10 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Mon, 26 Feb 2024 11:20:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1708964410; x=1709050810; bh=FOYwtQibxg xYSfvclhSVGEeajepdg7/RrzYTrMq4NWw=; b=FMpQvOIQdYgHL9DDnr7VNBUl05 g/KNW8dhdBZ8/ONAVmH+kyw0/+SsRJn0HvfWbcH4PxeFEaNUSb2oOPyiCGimlnxm cOapmXiy4Gxmi0meOwG4uR0UXAR7Z4iotUwKmx1jwBvs9uYUtV6gFby7DZLzZIYa wGMtpOPtZ8KlUC7GhrCwuGg+wEtJuM43YkriUaJvI7wfO829Kd5hu5asf4TrWbeW xFSLQOUeSfpQyrTidpSt69G6vsbh8ayRYYmNNjn4UUcyEzLNLDOPrdLFUTNZVOJR r31ElVXbBXWXOT3/jlKAVaTtW/YBvbbpJlDGz1U1quF68LcH80YRMADvuing== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1708964410; x=1709050810; bh=FOYwtQibxgxYSfvclhSVGEeajepd g7/RrzYTrMq4NWw=; b=dMXS6r4Tq8yi2r2uQWj7keJv2WNT4HIOr74u5y9bQ5bQ mU35O57e2/ZyLHNNYtKBUATl4X5L4Km2ZROs07YR0nHi/jaGd4gzmsprzBkyC2ns 1/35Rvw2Y5+lSOVJTq9IyT5GB579ei4zHEkTInONqDiZjWLeZX+si6nAPPOEBRey r4B8LRi34zTbJ7nlvVY1k4ir/KaSjfOJvOXwjjj9bh4RAk1XD30QgdiTj2cK0E5G UAItg+IUmqL1yxgrjxLI5ZOakFOGed/ukb3OdXDcvFXWyRQP1D5yjAmfhEbJS9UP osgHJwv1FoAHfUExI6HSCAlLyJbCQdUZxR0E7vJTmQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrgedvgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 58A0BB6008D; Mon, 26 Feb 2024 11:20:10 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-153-g7e3bb84806-fm-20240215.007-g7e3bb848 MIME-Version: 1.0 Message-Id: <23e6b40b-deb4-4e94-b454-cb2af0543af1@app.fastmail.com> In-Reply-To: <871q8zkygb.fsf@somnus> References: <0fe0add2-6b17-441f-a0e1-7c1ee9b0ea71@app.fastmail.com> <871q8zkygb.fsf@somnus> Date: Mon, 26 Feb 2024 17:19:49 +0100 From: "Arnd Bergmann" To: "Anna-Maria Gleixner" , "Naresh Kamboju" , "open list" , lkft-triage@lists.linaro.org, "Linux ARM" , "Thomas Gleixner" , "Vincenzo Frascino" Cc: "Ard Biesheuvel" , "Catalin Marinas" , "Kees Cook" Subject: Re: arch/arm64/include/asm/atomic_ll_sc.h:298:9: error: unknown type name 'u128' X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_082016_297682_F4D0E862 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 26, 2024, at 17:00, Anna-Maria Behnsen wrote: > "Arnd Bergmann" writes: >> Commit a0d2fcd62ac2 ("vdso/ARM: Make union vdso_data_store >> available for all architectures") introduced a reference to >> the asm/page.h in include/vdso/datapage.h, but this is outside >> of the vdso/*.h namespace and doesn't work in the compat vdso. > > But the asm namespace works for the vdso namespace. Only linux headers > do not work, or am I wrong? The vdso namespace was added to have something that works for userspace code in both compat 32-bit mode and native (32 or 64) bit mode, while anything outside of include/vdso may not work here. > PAGE_SIZE is defined in asm/page-def.h for arm64. So this could be a > fast fix (tested with clang-14): > > ---8<---- > --- a/include/vdso/datapage.h > +++ b/include/vdso/datapage.h > @@ -19,7 +19,11 @@ > #include > #include > > +#ifdef CONFIG_ARM64 > +#include > +#else > #include > +#endif > > #ifdef CONFIG_ARCH_HAS_VDSO_DATA > #include > ---8<--- I've sent my own patch now, which is something we probably want anyway, but is obviously much more invasive thank your four-line patch. Maybe we can put your quick fix in the tip tree for the moment and I put my patches into the asm-generic tree, then we can do the trivial cleanup from my final patch later. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel