From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAB0AC021BC for ; Mon, 24 Feb 2025 13:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=udmplEGWWz3RbBmcUEgC+DLlV0q/gZacDj16NiR6nHI=; b=0CurIFarPburak646rULg0KFdr HQyzF91TbBZT+CsTWHGlUCBg22rawiH4jIftLEn89W78b7FEROyYH8VwQkaccHIQ1ilJPYGahTzlL ujqCJAb+2Wh2dn8zg9ZXWq0QlUMeARdfT2S0SORbW4hi+wmLNz2Iy+c5WUSMR5p7d3BFfflGyc+s+ gus5uChyn3frP2MCe6KnrntgGZ5/OKUAAzxy4kJLifnYR7bkoPnr9uWDg3RMYuyR/tdv+6cSTRi6M uiyJjyFBaySWJkz9SGkO8iUhvVHkIi8xM1GLHZd9XkzxL+JO6CFmVMyn4yFGNiLN/TZMETOulbK03 g4hC1j3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tmYHK-0000000Dn28-3kvW; Mon, 24 Feb 2025 13:13:46 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tmXFX-0000000DcTh-36JC for linux-arm-kernel@lists.infradead.org; Mon, 24 Feb 2025 12:07:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 638CA611A0; Mon, 24 Feb 2025 12:07:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B3E2C4CEE6; Mon, 24 Feb 2025 12:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740398870; bh=ROIFuQUAjanRIwif6W4QK8e5P4N/acwvRXpzO4jIs1A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bHpYXV6+erqoGUMEMjSB1qxTN49g7TgYwhhrU7XyQbt+kQvaLHebVIzLeD3xjpxax NpiRqD6kbEr33vG1HvuJtisO4PwoPoZNfUN8EDJYVeX28wemBZkJVmfknin521RoT+ 32pJUieWfr57g93yx76n5/bAUwLmPzzv9J0nEgmoCe8j3qDZolDnln9h13hvoCZjZO Oj1JZwJULLogD8jcC52pzTuC4FP6jpLt4A8JSvL6yOXIzcUOa7rbMSFYwjxlxaiA4K tM39PlmMkpiYGrJIlCkdEgADeQnxDkHre0JdM0O0oaDiQ6VbbYbmClZN86fTT6DE7d uClr2+OAlQolQ== Message-ID: <24003082-d1ca-43c6-ae96-3705e0f964f0@kernel.org> Date: Mon, 24 Feb 2025 13:07:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support To: Peter Chen Cc: Arnd Bergmann , Rob Herring , krzk+dt@kernel.org, Conor Dooley , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com, "Fugang . duan" References: <20250220084020.628704-1-peter.chen@cixtech.com> <20250220084020.628704-7-peter.chen@cixtech.com> <4add2867-8c09-454a-b3e2-b4baaeccfd44@app.fastmail.com> <5f88cdbe-f396-49c6-bb48-f50cbbb21caf@kernel.org> <0bd5af6c-979b-4403-b1e7-5847979a8780@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/02/2025 11:39, Peter Chen wrote: >>>>>> >>>>>>> + sky1_fixed_clocks: fixed-clocks { >>>>>>> + uartclk: uartclk { >>>>>>> + compatible = "fixed-clock"; >>>>>>> + #clock-cells = <0>; >>>>>>> + clock-frequency = <100000000>; >>>>>>> + clock-output-names = "uartclk"; >>>>>> >>>>>>> + uart_apb_pclk: uart_apb_pclk { >>>>>>> + compatible = "fixed-clock"; >>>>>>> + #clock-cells = <0>; >>>>>>> + clock-frequency = <200000000>; >>>>>>> + clock-output-names = "apb_pclk"; >>>>>> >>>>>> >>>>>> Clock names don't need "clk" in them, and there should >>>>>> be no underscore -- use '-' instead of '_' when separating >>>>>> strings in DT. >>>>> >>>>> Will change to: >>>>> uart_apb: clock-uart-apb { >>>> >>>> No, instead explain why this is part of SoC - or what are you missing >>>> here - and use preferred naming. >>> >>> It is in SoC part, APB clock uses to visit register, and the function >>> amba_get_enable_pclk at file drivers/amba/bus.c needs it during uart >>> device probes. It uses common Arm uart pl011 IP, the binding doc >>> described at: Documentation/devicetree/bindings/serial/pl011.yaml >> >> So you added fake clock? Everything you wrote is not the reason to add >> such clock. > > Not a fake clock, it is the real clocks, but depends on firmware open > their parents and configure their rate. It could let others do their In one place you speak about UART, which is the consumer and not relevant. Here you mention it is real clock. That's all confusing, so to clarify: We talk about clock which is generated/output by something. Something which controls way it is generated is clock controller. Either you have here crystal or have here clock controller. If first, fixed clock is for that. If second, you need proper clock controller binding. You can add stubs for missing pieces, but this requires explanation and TODO/FIXME comment. > upstream work based on workable console. > > Which option you would like to accept? You did not describe the hardware, so I have no clue what is there. Best regards, Krzysztof