From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port
Date: Fri, 14 Jun 2013 00:06:51 +0200 [thread overview]
Message-ID: <24013808.T2v7Fa5NMK@wuerfel> (raw)
In-Reply-To: <1371131025-12200-2-git-send-email-maxime.ripard@free-electrons.com>
On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote:
> +
> + ahb at 80080000 {
> + usb0: usb at 80080000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb0_otg_cfa10036>;
> + status = "okay";
> };
> };
>
The patches all look good, just one trivial comment about the fragment above:
There is already a "usb0" label in the imx28.dtsi file for the same
node. When you refer to the node from a board.dts file, either leave
out the redundant label, or use it to simplify the statements above
to the brief version:
&usb0 {
pinctrl-names = "default";
pinctrl-0 = <&usb0_otg_cfa10036>;
status = "okay";
};
Arnd
next prev parent reply other threads:[~2013-06-13 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 13:43 [PATCH 0/4] ARM: mxs: Various Crystalfontz DT additions Maxime Ripard
2013-06-13 13:43 ` [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port Maxime Ripard
2013-06-13 22:06 ` Arnd Bergmann [this message]
2013-06-14 6:30 ` Shawn Guo
2013-06-14 6:39 ` Shawn Guo
2013-06-14 11:02 ` Maxime Ripard
2013-06-13 13:43 ` [PATCH 2/4] ARM: cfa10049: Switch the chip select pin of the LCD controller Maxime Ripard
2013-06-13 13:43 ` [PATCH 3/4] ARM: mxs: dt: Add the Crystalfontz CFA-10055 device tree Maxime Ripard
2013-06-16 11:51 ` Thomas Petazzoni
2013-06-13 13:43 ` [PATCH 4/4] ARM: mxs: dt: Add Crystalfontz CFA-10057 " Maxime Ripard
2013-06-14 6:51 ` [PATCH 0/4] ARM: mxs: Various Crystalfontz DT additions Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24013808.T2v7Fa5NMK@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox