From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB147D18129 for ; Mon, 14 Oct 2024 15:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eFrF5m8xHotibSlyzyFfwtr5WfnMN02kXFHWxTX8YAU=; b=Z+IdWDAW0iFQg8plRouhnHDYbN m1JEKMSEXPEA+I0vSsUeyBxM9Wpqx1uleeHZ/SFwkWQHpYFHkhcBr9jOSPu4TdnBARdxNUHd2k/SH wcVWKU8OSHlXeVZJ7HcxG4rq6jZ3oARz6+WimIR0zNGs3jtLqYbWn7QtN5rVTabEsUHXoZwCqFGGZ CjmgkCXr0gYpMNpaIWxzNxV0aW4rppZ26yKX79Csh6BX8jNITRLhobRJYbRKQB8bqQN6/LYZ3JZfG Pu9ajxTbqo9Itr6YHe8UQIOzQz3u9mDVAXuvvdYCY/Zo9VTxSzgfbOQs6Az93kmoofwGf3zBqUUb/ kC5mOEjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0NDd-00000005jnG-1GCN; Mon, 14 Oct 2024 15:42:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0NBt-00000005jRG-0n58 for linux-arm-kernel@bombadil.infradead.org; Mon, 14 Oct 2024 15:41:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=eFrF5m8xHotibSlyzyFfwtr5WfnMN02kXFHWxTX8YAU=; b=QgBnHoMwcJpDHStidEF5KsKUvk uAxLBIJYgjAbwb2GNPEQUzWgwUwuofSasH96HvJUyFe0djQB8r/5X1+1i9sYUYloXuYKjz4s5gQzk TKvIbdckXv3zfCGX1iIGSU4COVDVyWh1LsQqyKbzF9p7UFsum2an7M9LiWhMTtTN96h4yY5oIB4i0 0Fce+VGJ2Aj0VZQE7BsQiinoRfCVnqV6fTurJXSxV2mJZvQPiy8Tvl+3CwkUHwCDTtoMOJaKU6co8 iBr4vfR7LEflIBVfuS8AuEMquRICDzWe/mdRYyGOr9un7NIMr2zlryVYQbtdCY8LEc3hns4NzZAMr rvjkZ1Jg==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0NBp-00000006NAo-3ziU for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2024 15:40:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 518851007; Mon, 14 Oct 2024 08:41:24 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 149033F51B; Mon, 14 Oct 2024 08:40:53 -0700 (PDT) Message-ID: <24019386-6ecc-4715-9486-503ccc828113@arm.com> Date: Mon, 14 Oct 2024 16:40:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf: arm-ccn: remove unused macros To: Mark Rutland , Ba Jing Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241012091629.2369-1-bajing@cmss.chinamobile.com> From: Robin Murphy Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_164058_203120_8F30D181 X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/10/2024 10:19 am, Mark Rutland wrote: > On Sat, Oct 12, 2024 at 05:16:29PM +0800, Ba Jing wrote: >> By reading the code, I found these marcos are never >> referenced in the code. Just remove them. >> >> Signed-off-by: Ba Jing > > These are control bit values, so I don't see a strong reason to delete > them unless we're certain we're not going to use them in future. > > Anyhow, Robin Murphy wrote this driver, so its up to him. Please Cc him > for any changes to this driver in future. Er, this is CCN - FWIW I didn't claim this one, nor CCI, as supported in my maintainers entry largely because active development on them has long finished, but also because I *didn't* write them, so wouldn't claim to understand them much better than you or Will do ;) However, I'd agree that there doesn't seem to be any significant benefit to removing these (certainly showing at a glance that ALL_ERRORS_DISABLE is composed equivalently to PMU_EVENTS_DISABLE seems like no bad thing.) Thanks, Robin. > > Mark. > >> --- >> drivers/perf/arm-ccn.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c >> index 5c66b9278862..ea878b025d32 100644 >> --- a/drivers/perf/arm-ccn.c >> +++ b/drivers/perf/arm-ccn.c >> @@ -28,12 +28,7 @@ >> >> #define CCN_MN_ERRINT_STATUS 0x0008 >> #define CCN_MN_ERRINT_STATUS__INTREQ__DESSERT 0x11 >> -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__ENABLE 0x02 >> -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLED 0x20 >> #define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLE 0x22 >> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_ENABLE 0x04 >> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLED 0x40 >> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLE 0x44 >> #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__ENABLE 0x08 >> #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLED 0x80 >> #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLE 0x88 >> -- >> 2.33.0 >> >> >>