From: "Heiko Stübner" <heiko@sntech.de>
To: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Trevor Woerner <twoerner@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: rockchip: dts: rk3328-rock-pi-e: enable GbE eth
Date: Sun, 24 Dec 2023 19:59:36 +0100 [thread overview]
Message-ID: <2404910.8hb0ThOEGa@diego> (raw)
In-Reply-To: <20231221062244.11871-1-twoerner@gmail.com>
Hi Trevor,
Am Donnerstag, 21. Dezember 2023, 07:22:43 CET schrieb Trevor Woerner:
> Adjust the device-tree to get the GbE interface working using a patch found
> on the Radxa forum.
>
> Link: https://forum.radxa.com/t/rock-pi-e-board-version-1-21-ethhernet-not-working-in-armbian/15061/3
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> @@ -165,15 +165,17 @@ mdio {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - rtl8211e: ethernet-phy@1 {
> + rtl8211f: ethernet-phy@1 {
> + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
skipping through that thread, it looks like there are variants of the
board with one of the rtl8211e _or_ rtl8211f phys.
So while the "ethernet-phy-ieee802.3-c22" compatible would work for both,
the "ethernet-phy-id001c.c916" compat effectively disables phy- probing.
So applying this patch would effectively disable ethernet support on those
older rock-pi-e boards?
In a similar context concerning boards using different phys, it was
suggested [0] that the bootloader should modify the dt it passes to the
kernel to provide the correct phy id.
> reg = <1>;
> pinctrl-0 = <ð_phy_int_pin>, <ð_phy_reset_pin>;
> pinctrl-names = "default";
> interrupt-parent = <&gpio1>;
> interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> - reset-assert-us = <10000>;
> - reset-deassert-us = <50000>;
> + reset-assert-us = <20000>;
> + reset-deassert-us = <100000>;
I guess for those we can consolidate onto the "slower" ones in the kernel though.
> reset-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
> + max-speed = <1000>;
> };
> };
> };
>
Heiko
[0] https://lore.kernel.org/all/ecbdcfb7-32ab-45cc-991a-982c52bf4b14@gmail.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-12-24 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 6:22 [PATCH] arm64: rockchip: dts: rk3328-rock-pi-e: enable GbE eth Trevor Woerner
2023-12-24 18:59 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2404910.8hb0ThOEGa@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).