From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF294C433E3 for ; Sun, 16 Aug 2020 11:37:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8030A20760 for ; Sun, 16 Aug 2020 11:37:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bRmJiHs9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="HU9tb06V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8030A20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v0N5eu9L2JAWdvyVetY+lBk54oET3iiMY3c8CdADa64=; b=bRmJiHs9hCzrPBwjvrc4g8ebj 2cS4xUZ0m+ptXC2CAhDdyAKn4ZzxqdJpJDfg4fZCZWQOrKjQZHTSxRKuiQv7HF0Aj813Lk93q6kSy cwi2VvOZqf3n2eT2MaOrOTZkV2nzO3WrgPAvf/HUuUMUscA43um2v7uWubYAO5ZKTN/7TGCfTIr+I 9X/Ouuex5zs5NrKUyss0tfabEpSAED8iJWDPdG4nL8UW3UX1JwBeGc3Y5Z4m0Xie6p3fKB9JnabeD YIt+e3QgQlXa0+bZvL8nRc1v4QO7bQktfAiZq0KvGGAUoDlSGe2Jm7yG5iMb4kIMjUgs+twq60SPS yK/Gzn2aA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7GxH-0006Pu-Cz; Sun, 16 Aug 2020 11:36:04 +0000 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7GxD-0006OD-Di for linux-arm-kernel@lists.infradead.org; Sun, 16 Aug 2020 11:36:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1597577760; x=1629113760; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding:subject; bh=4tTb9I93XH7QwyWX5/PO8LI1xvs2muBk6/ZVUvGSdWw=; b=HU9tb06VntClgyAydMzJcLqLv04CfkMF/LIjbg1MwCHDMlQWHfVEDaiz JxLUHzym3u+Nvyp0yxTCXmHBVCrmEDgwLbBDnfROWyw2udwlgQoFWXMD7 juCX7lhwkC3RpmpRd7AZDmGh/bKVWTxPHeFTFIz27hIhodD+D3k7tizvz w=; X-IronPort-AV: E=Sophos;i="5.76,320,1592870400"; d="scan'208";a="67056199" Subject: Re: [PATCH v9 2/2] EDAC: al-mc-edac: Introduce Amazon's Annapurna Labs Memory Controller EDAC Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 16 Aug 2020 11:35:56 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com (Postfix) with ESMTPS id 576D228212D; Sun, 16 Aug 2020 11:35:51 +0000 (UTC) Received: from EX13D01EUB001.ant.amazon.com (10.43.166.194) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 16 Aug 2020 11:35:50 +0000 Received: from [192.168.3.188] (10.43.160.156) by EX13D01EUB001.ant.amazon.com (10.43.166.194) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 16 Aug 2020 11:35:42 +0000 To: Borislav Petkov References: <20200728095155.18506-1-talel@amazon.com> <20200728095155.18506-3-talel@amazon.com> <20200815183358.GE25814@zn.tnic> <5d516c64-ecd8-6f36-5f95-6708fe0f3fd5@amazon.com> <20200816112244.GG21914@zn.tnic> From: "Shenhar, Talel" Message-ID: <241ac8f0-964b-10d1-2d7b-eb9f435748a6@amazon.com> Date: Sun, 16 Aug 2020 14:35:37 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200816112244.GG21914@zn.tnic> Content-Language: en-GB X-Originating-IP: [10.43.160.156] X-ClientProxiedBy: EX13D01UWA002.ant.amazon.com (10.43.160.74) To EX13D01EUB001.ant.amazon.com (10.43.166.194) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200816_073559_716215_59FA0D1E X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, hhhawa@amazon.com, gregkh@linuxfoundation.org, eitan@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, catalin.marinas@arm.com, ronenk@amazon.com, mchehab@kernel.org, will@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/16/2020 2:22 PM, Borislav Petkov wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Sun, Aug 16, 2020 at 12:17:31PM +0300, Shenhar, Talel wrote: >> Let me know what you think. > Well, devm_al_mc_edac_free() devm_al_mc_edac_del() look like useless > wrappers to me and can be removed and you can use edac_mc_del_mc() and > edac_mc_free() directly. But then you need to cast them in an ugly way > so that it builds: > > ret = devm_add_action(&pdev->dev, (void (*)(void *data))edac_mc_free, mci); > > I guess we can leave them as is and then lift them into the EDAC core if > someone else wants to do the same devm_* thing. > > al_mc_edac_get_scrub_mode() doesn't need a prefix because it is used > only once and the compiler is simply inlining it so you can forget the > stack trace visibility: > > $ readelf -s drivers/edac/al_mc_edac.ko | grep scrub > $ > > The others are fine, I guess, since they're function pointers and cannot be > inlined as such so you want them prefixed: > > $ readelf -s drivers/edac/al_mc_edac.ko | grep al_mc_edac > 23: 00000000 0 FILE LOCAL DEFAULT ABS al_mc_edac.c > 25: 00000000 4 FUNC LOCAL DEFAULT 1 devm_al_mc_edac_free > 27: 00000004 4 FUNC LOCAL DEFAULT 1 devm_al_mc_edac_del > 31: 00000124 24 FUNC LOCAL DEFAULT 1 al_mc_edac_irq_handler_ce > 35: 00000260 24 FUNC LOCAL DEFAULT 1 al_mc_edac_irq_handler_ue > 36: 00000278 56 FUNC LOCAL DEFAULT 1 al_mc_edac_check > 37: 000002b0 680 FUNC LOCAL DEFAULT 1 al_mc_edac_probe > 47: 00000000 20 FUNC LOCAL DEFAULT 3 al_mc_edac_driver_init > 51: 00000000 12 FUNC LOCAL DEFAULT 5 al_mc_edac_driver_exit > 53: 00000000 392 OBJECT LOCAL DEFAULT 16 al_mc_edac_of_match > 59: 00000000 104 OBJECT LOCAL DEFAULT 20 al_mc_edac_driver > 61: 00000000 0 FILE LOCAL DEFAULT ABS al_mc_edac.mod.c > 88: 00000000 392 OBJECT GLOBAL DEFAULT 16 __mod_of__al_mc_edac_of_m > > Thx. Thanks. shall be part of v10. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel