Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings

From: "Heiko Stübner" <heiko@sntech.de>
To: Tim Lunn <tim@feathertop.org>, KyuHyuk Lee <lee@kyuhyuk.kr>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chris Morgan <macromorgan@hotmail.com>,
	Tianling Shen <cnsztl@gmail.com>, Jagan Teki <jagan@edgeble.ai>,
	Ondrej Jirman <megi@xff.cz>, Andy Yan <andyshrk@163.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings
Date: Tue, 16 Jan 2024 09:31:35 +0100	[thread overview]
Message-ID: <2421144.zToM8qfIzz@diego> (raw)
In-Reply-To: <3dfe868d-ff8d-44ac-a68e-066ac42a6705@linaro.org>

Am Dienstag, 16. Januar 2024, 08:24:44 CET schrieb Krzysztof Kozlowski:
> On 16/01/2024 03:00, Tim Lunn wrote:
> > 
> > On 1/16/24 01:58, Krzysztof Kozlowski wrote:
> >> On 15/01/2024 15:51, KyuHyuk Lee wrote:
> >>> The vendor in ODROID-M1 is hardkernel, but it was incorrectly written
> >>> as rockchip. Fixed the vendor prefix correctly.
> >>>
> >>> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
> >>> ---
> >>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >> You need to start testing your patches. Your last M1 fails as well in
> >> multiple places.
> >>
> >> It does not look like you tested the DTS against bindings. Please run
> >> `make dtbs_check W=1` (see
> >> Documentation/devicetree/bindings/writing-schema.rst or
> >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> >> for instructions).
> >>
> >> The DTS change will break the users, so would be nice to mention this in
> >> its commit msg.
> > 
> > I notice there are a couple of other boards that incorrectly use 
> > rockchip as the vendor also:
> > 
> >            - const: rockchip,rk3399-orangepi
> >            - const: rockchip,rk3568-bpi-r2pro
> > 
> > Perhaps these should also be fixed at the same time?
> 
> What is happening with rockchip boards?

Copy-paste stuff ... boards using rockchip,boardname instead of
vendor,boardname for their compatible.

I do remember us noticing this a number of times on some boards
and requesting fixes, but looks like some slipped through.

So I guess Tim is suggesting changing the compatible, but with boards
being merged a while ago, this would break backwards compatibility.
So I guess both the Orange and Banana Pies will need to live with that.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel