From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 423CFC4345F for ; Tue, 30 Apr 2024 21:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=giBJ4f5MzCU6+i8Q03xESHscoifAEkDBAXTzKS8pYoM=; b=iJg0Y9V6IDV+5c UfI/l60Ik+qMWnL4Mu0os8vBqTiWC79xA1oJRx04oX6mtfmMPfFZ0jHPUeWfdx24ci5hl35PqxaKT gFXxWdwQAIaqWjzsYpgWDKvUoBV65wRR1l+RezANhvjqzvD8691JBw6uDh/KPDZMkpw3ZSnJaIXJ2 yZJlYFgW1BaL7rmebyqJcAuOuIVzT0Y41ki3yEgr6kJd2R6wjf9dLe2gdHrraZZMI7edp3vjQV4LM 2SKL1KXWJfO4+AXtrIkLg73LBj7hNy6vVBqduCvKIA+YH5FLxzvmsITQ6ChrnBn4kLxU/zLyM6x60 I+Xbs478FQlKvrZ1PHTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1v2n-00000007yH6-3vpd; Tue, 30 Apr 2024 21:29:45 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1v2l-00000007yFl-2ZKR for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 21:29:45 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-41adf155cffso44729135e9.2 for ; Tue, 30 Apr 2024 14:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714512580; x=1715117380; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=TZ2y81c2byjlveBh1HAofGMkjm8xCH8OK2yGcAkdmF0=; b=Qnn6s+aoWUO+Rksb/huK6THXDs8Iz7xmgAyh1Sg4bG/v7oMYNNcHoeTWzmOPODb/9y Zi7juVd7v+/0CLIoJC0wOzvKfhO1h3lGKnVmePeK7xE+CwsXz3ERpezSBiFOrGXEEm0j KaF92u6eU7brsrQ2sAoRGfEPps+FgWucPq7DlatoRnkVnr/+8tsDe0QaNHxx8u5HmEqB CMWq/1bAg+pltUpSGTo6BFcDjVsWr9RJcGzLS3AifB091jfRrJkiYJaszpXXoOP5LNBy PAM4PZiDRrkeyy0Fyn/O/hlQRODoQZkJMCKW+7wyhkat7VQM5GTMxjJr3lxIVFYlk/FQ bH+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714512580; x=1715117380; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TZ2y81c2byjlveBh1HAofGMkjm8xCH8OK2yGcAkdmF0=; b=teXz599GOgKlqDZZevbUxY1/4UnWYZDJyVYtjc//PA5J1LJkCSy9fcZMvI04cTyhBF nwF+U9ZNU32HMJwVHITmtnwEfCFZYL6NFeHuNbaXBd/y2LqzelRGILqoEirML1M1Epxq Ihx2pyKehIVCAVEqBR1dRUysbD+j4HZr4sHsMrUcQjUqZGwfSmooYgimnPPWo8512kog UI4I+9DiZlTRbVKtlV+wE2xaW22oLUk8YfhOlYe/6aj4UVU/kgCpoCs7h9mbP7Ew9P01 FMt93/sl3UiNRb/Cv7+tmlB+1oPs+0aqZScpDOiup8SfL0Pj9J0rjFXJB7BwzMqtWIb2 ZP9Q== X-Forwarded-Encrypted: i=1; AJvYcCWLW88dn8H+cJUnMQkKEogWTbQ5cOBPMYOdyq38Qrw491Xm4PCcQVoVNhblp7hLVTTCE27ymqdIy86DB0XbvdEe+pTLUYm1VuukwmsFypJqYiEYhfU= X-Gm-Message-State: AOJu0YxgZmBvY0cyiRoxqxggWl4nRy9dTBNf0QeR/5wWpK2cy3FEcDML pmxvBhUJT6w0VkqOClwZ5bohzPm7AMlQiqjGiCWd0WJnIyG+1SU0 X-Google-Smtp-Source: AGHT+IEHCnF0NSG99DEHe9lxmu+Temen/zUTzj7bR+E5VYP2Bo430zxOHiyAbM6EHKNq+9iuMPFVfw== X-Received: by 2002:a5d:4bc7:0:b0:34d:7d03:4602 with SMTP id l7-20020a5d4bc7000000b0034d7d034602mr614567wrt.1.1714512580100; Tue, 30 Apr 2024 14:29:40 -0700 (PDT) Received: from ?IPV6:2a01:c22:72f1:1900:dd93:acce:2a2a:774d? (dynamic-2a01-0c22-72f1-1900-dd93-acce-2a2a-774d.c22.pool.telefonica.de. [2a01:c22:72f1:1900:dd93:acce:2a2a:774d]) by smtp.googlemail.com with ESMTPSA id z10-20020a05600c220a00b0041bef325c4esm7057100wml.1.2024.04.30.14.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 14:29:39 -0700 (PDT) Message-ID: <2422613d-0f9c-4485-bad3-5aa7cf12c0b1@gmail.com> Date: Tue, 30 Apr 2024 23:29:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: phy: Don't conditionally compile the phy_link_topology creation To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , Jesse Brandeburg , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart References: <20240429131008.439231-1-maxime.chevallier@bootlin.com> <1ed5b8cb-c79b-44b9-8dbe-f78d7505b3b4@gmail.com> <20240430135734.503f51a2@device-28.home> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <20240430135734.503f51a2@device-28.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_142943_707924_35D360CD X-CRM114-Status: GOOD ( 27.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30.04.2024 13:57, Maxime Chevallier wrote: > Hello Heiner, > > On Tue, 30 Apr 2024 10:17:31 +0200 > Heiner Kallweit wrote: > >> On 29.04.2024 15:10, Maxime Chevallier wrote: >>> The core of the phy_link_topology isn't directly tied to phylib, and at >>> the moment it's initialized, phylib might not be loaded yet. Move the >>> initialization of the topology to the phy_link_topology_core header, >>> which contains the bare minimum so that we can initialize it at netdev >>> creation. >>> >> >> The change fixes the issue for me, but according to my personal taste >> the code isn't intuitive and still error-prone. Also there's no good >> reason to inline a function like phy_link_topo_create() and make it >> publicly available. Do you expect it to be ever used outside net core? >> In general it may make sense to add a config symbol for the topology >> extension, there seem to be very few, specialized use cases for it. > > I think I'm missing the point here then. Do you mean adding a Kconfig > option to explicitely turn phy_link_topology on ? or build it as a > dedicated kernel module ? > > Or do you see something such as "if phylib is M or Y, then build the > topology stuff and make sure it's allocated when a netdev gets created > ?" > > Thanks, > > Maxime > >> >>> Signed-off-by: Maxime Chevallier >>> Closes: https://lore.kernel.org/netdev/2e11b89d-100f-49e7-9c9a-834cc0b82f97@gmail.com/ >>> Closes: https://lore.kernel.org/netdev/20240409201553.GA4124869@dev-arch.thelio-3990X/ >>> --- >>> drivers/net/phy/phy_link_topology.c | 23 -------------------- >>> include/linux/phy_link_topology.h | 5 ----- >>> include/linux/phy_link_topology_core.h | 30 +++++++++++++++++--------- >>> 3 files changed, 20 insertions(+), 38 deletions(-) >>> >>> diff --git a/drivers/net/phy/phy_link_topology.c b/drivers/net/phy/phy_link_topology.c >>> index 985941c5c558..960aedd73308 100644 >>> --- a/drivers/net/phy/phy_link_topology.c >>> +++ b/drivers/net/phy/phy_link_topology.c >>> @@ -12,29 +12,6 @@ >>> #include >>> #include >>> >>> -struct phy_link_topology *phy_link_topo_create(struct net_device *dev) >>> -{ >>> - struct phy_link_topology *topo; >>> - >>> - topo = kzalloc(sizeof(*topo), GFP_KERNEL); >>> - if (!topo) >>> - return ERR_PTR(-ENOMEM); >>> - >>> - xa_init_flags(&topo->phys, XA_FLAGS_ALLOC1); >>> - topo->next_phy_index = 1; >>> - >>> - return topo; >>> -} >>> - >>> -void phy_link_topo_destroy(struct phy_link_topology *topo) >>> -{ >>> - if (!topo) >>> - return; >>> - >>> - xa_destroy(&topo->phys); >>> - kfree(topo); >>> -} >>> - >>> int phy_link_topo_add_phy(struct phy_link_topology *topo, >>> struct phy_device *phy, >>> enum phy_upstream upt, void *upstream) >>> diff --git a/include/linux/phy_link_topology.h b/include/linux/phy_link_topology.h >>> index 6b79feb607e7..ad72d7881257 100644 >>> --- a/include/linux/phy_link_topology.h >>> +++ b/include/linux/phy_link_topology.h >>> @@ -32,11 +32,6 @@ struct phy_device_node { >>> struct phy_device *phy; >>> }; >>> >>> -struct phy_link_topology { >>> - struct xarray phys; >>> - u32 next_phy_index; >>> -}; >>> - >>> static inline struct phy_device * >>> phy_link_topo_get_phy(struct phy_link_topology *topo, u32 phyindex) >>> { >>> diff --git a/include/linux/phy_link_topology_core.h b/include/linux/phy_link_topology_core.h >>> index 0a6479055745..0116ec49cd1b 100644 >>> --- a/include/linux/phy_link_topology_core.h >>> +++ b/include/linux/phy_link_topology_core.h >>> @@ -2,24 +2,34 @@ >>> #ifndef __PHY_LINK_TOPOLOGY_CORE_H >>> #define __PHY_LINK_TOPOLOGY_CORE_H >>> >>> -struct phy_link_topology; >>> +#include >>> >>> -#if IS_REACHABLE(CONFIG_PHYLIB) >>> - >>> -struct phy_link_topology *phy_link_topo_create(struct net_device *dev); >>> -void phy_link_topo_destroy(struct phy_link_topology *topo); >>> - >>> -#else >>> +struct phy_link_topology { >>> + struct xarray phys; >>> + u32 next_phy_index; >>> +}; >>> >>> static inline struct phy_link_topology *phy_link_topo_create(struct net_device *dev) >>> { >>> - return NULL; >>> + struct phy_link_topology *topo; >>> + >>> + topo = kzalloc(sizeof(*topo), GFP_KERNEL); >>> + if (!topo) >>> + return ERR_PTR(-ENOMEM); >>> + >>> + xa_init_flags(&topo->phys, XA_FLAGS_ALLOC1); >>> + topo->next_phy_index = 1; >>> + >>> + return topo; >>> } >>> >>> static inline void phy_link_topo_destroy(struct phy_link_topology *topo) >>> { >>> -} >>> + if (!topo) >>> + return; >>> >>> -#endif >>> + xa_destroy(&topo->phys); >>> + kfree(topo); >>> +} >>> >>> #endif /* __PHY_LINK_TOPOLOGY_CORE_H */ >> > To go a little bit more into detail: phy_link_topo_create() and phy_link_topo_destroy() are used in net/core/dev.c only. Do you expect them to be ever used by other callers? If not, their functionality could be moved to net/core/dev.c. Supposedly guarded by IS_ENABLED(CONFIG_PHYLIB), alternatively a new config symbol for link_topo support. To get rid of the dependency you could also lazy-inizialize netdev->link_topo. For this phy_link_topo_add_phy() would have to take the netdev as first argument, not the topo. Then the first call to phy_link_topo_add_phy() would initialize netdev->link_topo. I think functions like phy_link_topo_get_phy() should also check for topo != NULL first, maybe combined with a WARN_ON(). They are exported and you have no control over its use. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel