public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: kernel@collabora.com, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] RK3588 rockchip-dfi enhancements
Date: Fri, 20 Jun 2025 18:08:53 +0200	[thread overview]
Message-ID: <2422670.VLH7GnMWUR@workhorse> (raw)
In-Reply-To: <20250530-rk3588-dfi-improvements-v1-0-6e077c243a95@collabora.com>

On Friday, 30 May 2025 15:38:07 Central European Summer Time Nicolas Frattaroli wrote:
> This series consists of two related patches. The first fixes the memory
> cycle counter on RK3588, which read half of what it should've been
> reading. You can easily verify this with
> 
>   perf stat -a -e rockchip_ddr/cycles/ sleep 1
> 
> and then dividing the result by the number of Hertz the ddr init settles
> on, which for LPDDR4X on RK3588 appears to be 2112MHz.
> 
> The second adds support for measuring memory bandwidth with LPDDR5
> memory. Results have been validated by comparing its reported bandwidth
> with that reported by stress-ng --stream 8 --timeout 15, which line up
> almost perfectly.
> 
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
> Nicolas Frattaroli (2):
>       PM / devfreq: rockchip-dfi: double count on RK3588
>       PM / devfreq: rockchip-dfi: add support for LPDDR5
> 
>  drivers/devfreq/event/rockchip-dfi.c | 91 ++++++++++++++++++++++++++++--------
>  include/soc/rockchip/rk3588_grf.h    |  8 +++-
>  include/soc/rockchip/rockchip_grf.h  |  1 +
>  3 files changed, 79 insertions(+), 21 deletions(-)
> ---
> base-commit: ba2b2250bbaf005016ba85e345add6e19116a1ea
> change-id: 20250530-rk3588-dfi-improvements-f646424715d2
> 
> Best regards,
> 

I see someone has merged patch 1 into -next without leaving a message,
but patch 2 was not picked.

Could this mysterious patron saint of PM / devfreq make themselves
heard and let me know whether they would like to see a second revision
of patch 2, and if so, what said revision should address?

I am asking specifically as I would like to continue working on the
driver in a follow-up series, and BYEWORD_UPDATE already complicates
the situation by being another in-flight patch.

Kind regards,
Nicolas Frattaroli




      parent reply	other threads:[~2025-06-20 16:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-30 13:38 [PATCH 0/2] RK3588 rockchip-dfi enhancements Nicolas Frattaroli
2025-05-30 13:38 ` [PATCH 1/2] PM / devfreq: rockchip-dfi: double count on RK3588 Nicolas Frattaroli
2025-05-30 13:38 ` [PATCH 2/2] PM / devfreq: rockchip-dfi: add support for LPDDR5 Nicolas Frattaroli
2025-06-04  8:24   ` Diederik de Haas
2025-06-05 15:14     ` Nicolas Frattaroli
2025-06-05 19:49       ` Diederik de Haas
2025-06-11  7:32   ` Sascha Hauer
2025-09-06 16:09   ` Chanwoo Choi
2025-09-06 18:38     ` Heiko Stübner
2025-09-06 22:46       ` Chanwoo Choi
2025-09-06 18:37   ` Heiko Stübner
2025-06-20 16:08 ` Nicolas Frattaroli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2422670.VLH7GnMWUR@workhorse \
    --to=nicolas.frattaroli@collabora.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=cw00.choi@samsung.com \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox