Re: [PATCH] arm64: dts: rockchip: configure hdmirx in Rock 5 ITX

[Heiko Stuebner <heiko@sntech.de>]

Am Mittwoch, 4. März 2026, 21:05:52 Mitteleuropäische Normalzeit schrieb Pedro Alves:
> On 04/03/2026 18:38, Diederik de Haas wrote:
> > I have a strong suspicion that it was named 'hdmirx_det' because in the
> > schema its label is 'HDMIIRX_DET_L' where the extra 'I' was probably
> > dropped as that seems to be a spelling issue and the '_L' suffix is
> > quite often dropped.
> >
> > FWIW: The label in the schematic for Rock 5B, Rock 5B+, Rock 5T and Rock
> > 5 ITX+ are all 'HDMIIRX_DET_L', yet none of them follow the convention
> > to use the label from the schematics.
> 
> That's a good point, and the other boards all have the hdmirx_det
> naming in the downstream kernel, so I guess that would be the most
> "correct" name to use.
> 
> > So now the 'problem' is indeed: make it consistent with the other boards
> > or keep the one where the convention was followed.
> 
> Also a third option of changing the other boards to all match. Either
> way, I can do those changes, just let me know what would be desirable.

I really want pin-names to reflect the schematics. This makes searching
so much easier. Sometimes things slip through where that doesn't match,
but the goal would be to always move to improve things.

So at least the newly added hdmirx here should follow the schematics,
and if you are keen to bring everything in line, you could also change
the other boards. But please make sure via the schematics of those :-)


Thanks
Heiko