public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 4/5] ARM: hisi: enable devicetree support for hi3520
Date: Fri, 16 Sep 2016 09:56:52 +0200	[thread overview]
Message-ID: <2438843.7Op0NuNt2B@wuerfel> (raw)
In-Reply-To: <20160915210505.21878-5-netz.kernel@gmail.com>

On Thursday, September 15, 2016 4:05:04 PM CEST Marty Plummer wrote:
> @@ -24,17 +31,19 @@ config ARCH_HI3620
>  	  Support for Hisilicon Hi36xx SoC family
>  
>  config ARCH_HIP01
> -       bool "Hisilicon HIP01 family"
> -       depends on ARCH_MULTI_V7
> -       select HAVE_ARM_SCU if SMP
> -       select HAVE_ARM_TWD if SMP
> -       select ARM_GLOBAL_TIMER
> -       help
> -         Support for Hisilicon HIP01 SoC family
> +	bool "Hisilicon HIP01 family"
> +	depends on ARCH_MULTI_V7
> +	select ARM_GIC
> +	select HAVE_ARM_SCU if SMP
> +	select HAVE_ARM_TWD if SMP
> +	select ARM_GLOBAL_TIMER
> +	help
> +	  Support for Hisilicon HIP01 SoC family
>  

This change doesn't belong in here.

> @@ -28,6 +30,16 @@
>   * spaces wasted since ioremap() may be called multi times for the same
>   * IO space.
>   */
> +static struct map_desc hi3520_1176_io_desc[] __initdata = {
> +	{
> +		/* sysctrl */
> +		.virtual	= HI3520_1176_SYSCTRL_VIRT_BASE,
> +		.pfn		= __phys_to_pfn(HI3520_1176_SYSCTRL_PHYS_BASE),
> +		.length		= 0x10000,
> +		.type		= MT_DEVICE,
> +	},
> +};
> +
>  static struct map_desc hi3620_io_desc[] __initdata = {
>  	{
>  		/* sysctrl */


What do you need this for? I think it would be better to map the
device manually from whichever code uses itby looking it up 
in the DT.

	Arnd

  reply	other threads:[~2016-09-16  7:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 21:05 [RFC PATCH v2 0/5] Add support for hi3520 Marty Plummer
2016-09-15 21:05 ` [RFC PATCH v2 1/5] ARM: hisi: Make 3620 explicit, remove wildcards Marty Plummer
2016-09-16  7:54   ` Arnd Bergmann
2016-09-15 21:05 ` [RFC PATCH v2 2/5] clk: hi3620: Make 3620 explicit, remove wildcard Marty Plummer
2016-09-16  8:05   ` Arnd Bergmann
2016-09-15 21:05 ` [RFC PATCH v2 3/5] dmaengine: hi3620: Make hi3620 " Marty Plummer
2016-09-16  8:04   ` Arnd Bergmann
2016-09-15 21:05 ` [RFC PATCH v2 4/5] ARM: hisi: enable devicetree support for hi3520 Marty Plummer
2016-09-16  7:56   ` Arnd Bergmann [this message]
2016-09-15 21:05 ` [RFC PATCH v2 5/5] ARM: hisi: add devicetree " Marty Plummer
2016-09-16  8:02   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2438843.7Op0NuNt2B@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox