From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B560FC433ED for ; Mon, 12 Apr 2021 17:53:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B35D61042 for ; Mon, 12 Apr 2021 17:53:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B35D61042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=485gFcCY4mUSftnJH8YYoQlBU8Sby89NJ4k28TRU2jw=; b=IV1hUOWFrDRLUtjHLH39TqlN6 o1xr/rlb7VU5FIADEJmEQOE+WVgJ3UXZq7xcHFIFNHIZCjGOr5ztL38y5TZtefBDmtioqQn5nENr0 FzzWa6wJ6VorGhwKmL4KDmc+D9zaCInRhUxUaSms479h+53u7kSfLM8ckvzGmNM0Ze38e19pkwDRV 4ARDxVcjmM5P5FCFjjoz2lQVbN/Q73eAjLdSkeXfNWqxv74d2Lt9bVuy7ybsof6xnVtqXdIydy90p i2SKs2I8ZmNIUIy7EqD7fD6L+PeeEtY18oSwi/F0h+8xb/LWbouQh/8DrmzaoGrfCZbqiWFIqRm5X LnGrvFKpw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW0ix-007OEW-6J; Mon, 12 Apr 2021 17:51:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW0iu-007OEL-ET for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 17:51:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=dvC93P5dNvD0fMCJJCkypibtnt5baBaNB43Y90ksKkM=; b=CW/mrwSml9b6O+maqyS8QYpnh9 5HAs0IPdvPb25RY3GHD305f38hQbWXfAKJzadyi2rzNb7bIf7vQM3a9typTHsRDu9AmD1auxZVlfA NONtkUH/6MvE2ftbGG/WNHSBtrp2cG33EWdGY5GIF6feY5ICoRimCVu7UPFNePvuYnfWiI2A7hunD y2Lova218QdDo/DPcA9eoNl18s1QdM7NRepAiq4NjaO+Y2VxTQ765kVt09RDNTHw0QE9ao0M/hAay siSuKTxA530CX6PrbMBKz97ClP5QBe1XdRqIi2GyS1RG7BtpVRl6c93gRTeu0fxcgQqZAhAkGptX+ 7vYGjznQ==; Received: from mailoutvs9.siol.net ([185.57.226.200] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW0ir-006StC-90 for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 17:51:43 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id C4F8F5256A1; Mon, 12 Apr 2021 19:51:36 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id p7fWFXGhuUnB; Mon, 12 Apr 2021 19:51:36 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 7226B525715; Mon, 12 Apr 2021 19:51:36 +0200 (CEST) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net [86.58.17.133]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id D730F5256A1; Mon, 12 Apr 2021 19:51:35 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Andre Przywara , Michael Weiser Cc: Chen-Yu Tsai , Rob Herring , Maxime Ripard , devicetree , linux-arm-kernel , linux-sunxi , Daniel Kulesz Subject: Re: Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: Revert SD card CD GPIO for Pine64-LTS Date: Mon, 12 Apr 2021 19:51:35 +0200 Message-ID: <2453001.GT6EyWp2Io@kista> In-Reply-To: References: <20210412000813.13071-1-andre.przywara@arm.com> <20210412174558.4ba90cf8@slackpad.fritz.box> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_105141_503097_7827D729 X-CRM114-Status: GOOD ( 24.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 12. april 2021 ob 19:41:25 CEST je Michael Weiser napisal(a): > Hi Andre, ChenYu, > > On Mon, Apr 12, 2021 at 05:45:58PM +0100, Andre Przywara wrote: > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts b/ arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > > > > index e79ce49e7e6a..843338e19694 100644 > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > > > > @@ -21,5 +21,5 @@ > > > > }; > > > > > > > > &mmc0 { > > > > - cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 push-push switch */ > > > > + non-removable; /* card detect is broken on some boards */ > > > > > > So a revert is good, but has anyone tried using the "broken-cd" instead? > > Ha, that's a good idea, I totally forgot about this property! > > > > That way, at least on Linux, the mmc core resorts to polling for a card. > > > At least this way the card is still removable. > > Yes indeed, I tested it on my "stuck at 1" Pine64-LTS, and it works like > > a charm! > > > Daniel, Michael, can you test this on your boards? So removing the > > cd-gpios property, and adding "broken-cd;" instead? > > Yes, it works fine. What flummoxed me at first was that obviously I also > have to disable the ACTIVE_LOW definition in sun50i-a64-sopine.dtsi > after having added and disabled an ACTIVE_HIGH definition in > sun50i-a64-pine64-lts.dts. > > BTW: My boards have a marking "PINE64-R18-V1_1" and below it > "2017-08-03" on their upper side. On the back it says on one sticker > "Model:PineA64 2GB LTS" and on another "2O1-PINE64R18-00" and > "PINE64-R18-V1.1 2G". Is CD being stuck at 1 a bug of revision 1.0 > perhaps? Is there a way to detect this difference in software and add > some sort of quirk handler for it? This is job for bootloader (U-Boot) which can patch DT. Most Allwinner boards have no reliable way to be distinguished, except from Olimex. So I would say it's not possible. Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel