From: Sven Eckelmann <se@simonwunderlich.de>
To: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH mt76 v3] wifi: mt76: Fix DTS power-limits on little endian systems
Date: Mon, 20 Oct 2025 11:30:37 +0200 [thread overview]
Message-ID: <2453774.NG923GbCHz@ripper> (raw)
In-Reply-To: <20251020-fix-power-limits-v3-1-019d2e49239a@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]
On Monday, 20 October 2025 11:20:53 CEST Sven Eckelmann (Plasma Cloud) wrote:
> The power-limits for ru and mcs and stored in the devicetree as bytewise
> array (often with sizes which are not a multiple of 4). These arrays have a
> prefix which defines for how many modes a line is applied. This prefix is
> also only a byte - but the code still tried to fix the endianness of this
> byte with a be32 operation. As result, loading was mostly failing or was
> sending completely unexpected values to the firmware.
>
> Since the other rates are also stored in the devicetree as bytewise arrays,
> just drop the u32 access + be32_to_cpu conversion and directly access them
> as bytes arrays.
>
> Cc: stable@vger.kernel.org
> Fixes: 22b980badc0f ("mt76: add functions for parsing rate power limits from DT")
> Fixes: a9627d992b5e ("mt76: extend DT rate power limits to support 11ax devices")
> Signed-off-by: Sven Eckelmann (Plasma Cloud) <se@simonwunderlich.de>
> ---
> Changes in v3:
> - add "mt76" as addition prefix after "PATCH" as requested by Zhi-Jun You
> - Link to v2: https://lore.kernel.org/r/20250926-fix-power-limits-v2-1-c2bc7881eb6d@simonwunderlich.de
Seems like the v2 was already picked up [1] and I've simply missed it.
Sorry about the noise,
Sven
[1] https://github.com/nbd168/wireless/commit/3d63b5084c50607fff84d17d2727c3bab8190d8e
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-10-20 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 9:20 [PATCH mt76 v3] wifi: mt76: Fix DTS power-limits on little endian systems Sven Eckelmann (Plasma Cloud)
2025-10-20 9:30 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2453774.NG923GbCHz@ripper \
--to=se@simonwunderlich.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).