* [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
[not found] <20211124125506.2971069-1-daniel.lezcano@linaro.org>
@ 2021-11-24 12:55 ` Daniel Lezcano
2021-11-24 13:49 ` Robin Murphy
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2021-11-24 12:55 UTC (permalink / raw)
To: daniel.lezcano
Cc: robh, arnd, heiko, ulf.hansson, rjw, devicetree, linux-kernel,
linux-pm, lukasz.luba, Rob Herring, Johan Jonker,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
Add the powerzones description. This first step introduces the big,
the little and the gpu as a powerzone place.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
.../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
index 1a23e8f3cdf6..83540bdb64cd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
@@ -61,6 +61,51 @@ bt_active_led: led-6 {
};
};
+ powerzones {
+
+ PKG_PZ: pkg {
+ #powerzone-cells = <0>;
+ powerzone = <&SOC_PZ>;
+ };
+
+ SOC_PZ: soc {
+ };
+ };
+};
+
+&cpu_b0 {
+ #powerzone-cells = <0>;
+ powerzone = <&PKG_PZ>;
+};
+
+&cpu_b1 {
+ #powerzone-cells = <0>;
+ powerzone = <&PKG_PZ>;
+};
+
+&cpu_l0 {
+ #powerzone-cells = <0>;
+ powerzone = <&PKG_PZ>;
+};
+
+&cpu_l1 {
+ #powerzone-cells = <0>;
+ powerzone = <&PKG_PZ>;
+};
+
+&cpu_l2 {
+ #powerzone-cells = <0>;
+ powerzone = <&PKG_PZ>;
+};
+
+&cpu_l3 {
+ #powerzone-cells = <0>;
+ powerzone = <&PKG_PZ>;
+};
+
+&gpu {
+ #powerzone-cells = <0>;
+ powerzone = <&PKG_PZ>;
};
&cpu_alert0 {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
2021-11-24 12:55 ` [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960 Daniel Lezcano
@ 2021-11-24 13:49 ` Robin Murphy
2021-11-24 16:41 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Robin Murphy @ 2021-11-24 13:49 UTC (permalink / raw)
To: Daniel Lezcano
Cc: robh, arnd, heiko, ulf.hansson, rjw, devicetree, linux-kernel,
linux-pm, lukasz.luba, Rob Herring, Johan Jonker,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
On 2021-11-24 12:55, Daniel Lezcano wrote:
> Add the powerzones description. This first step introduces the big,
> the little and the gpu as a powerzone place.
These look more like SoC-level properties than board-level ones - should
they be in rk3399.dtsi?
Robin.
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> index 1a23e8f3cdf6..83540bdb64cd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> @@ -61,6 +61,51 @@ bt_active_led: led-6 {
> };
> };
>
> + powerzones {
> +
> + PKG_PZ: pkg {
> + #powerzone-cells = <0>;
> + powerzone = <&SOC_PZ>;
> + };
> +
> + SOC_PZ: soc {
> + };
> + };
> +};
> +
> +&cpu_b0 {
> + #powerzone-cells = <0>;
> + powerzone = <&PKG_PZ>;
> +};
> +
> +&cpu_b1 {
> + #powerzone-cells = <0>;
> + powerzone = <&PKG_PZ>;
> +};
> +
> +&cpu_l0 {
> + #powerzone-cells = <0>;
> + powerzone = <&PKG_PZ>;
> +};
> +
> +&cpu_l1 {
> + #powerzone-cells = <0>;
> + powerzone = <&PKG_PZ>;
> +};
> +
> +&cpu_l2 {
> + #powerzone-cells = <0>;
> + powerzone = <&PKG_PZ>;
> +};
> +
> +&cpu_l3 {
> + #powerzone-cells = <0>;
> + powerzone = <&PKG_PZ>;
> +};
> +
> +&gpu {
> + #powerzone-cells = <0>;
> + powerzone = <&PKG_PZ>;
> };
>
> &cpu_alert0 {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
2021-11-24 13:49 ` Robin Murphy
@ 2021-11-24 16:41 ` Daniel Lezcano
2021-11-24 16:52 ` Heiko Stübner
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2021-11-24 16:41 UTC (permalink / raw)
To: Robin Murphy
Cc: robh, arnd, heiko, ulf.hansson, rjw, devicetree, linux-kernel,
linux-pm, lukasz.luba, Rob Herring, Johan Jonker,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
On 24/11/2021 14:49, Robin Murphy wrote:
> On 2021-11-24 12:55, Daniel Lezcano wrote:
>> Add the powerzones description. This first step introduces the big,
>> the little and the gpu as a powerzone place.
>
> These look more like SoC-level properties than board-level ones - should
> they be in rk3399.dtsi?
Yes, it makes sense
If Heiko is fine with that I can add this description in the rk3399.dtsi
file
>> ---
>> .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++
>> 1 file changed, 45 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
>> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
>> index 1a23e8f3cdf6..83540bdb64cd 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
>> @@ -61,6 +61,51 @@ bt_active_led: led-6 {
>> };
>> };
>> + powerzones {
>> +
>> + PKG_PZ: pkg {
>> + #powerzone-cells = <0>;
>> + powerzone = <&SOC_PZ>;
>> + };
>> +
>> + SOC_PZ: soc {
>> + };
>> + };
>> +};
>> +
>> +&cpu_b0 {
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>> +};
>> +
>> +&cpu_b1 {
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>> +};
>> +
>> +&cpu_l0 {
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>> +};
>> +
>> +&cpu_l1 {
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>> +};
>> +
>> +&cpu_l2 {
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>> +};
>> +
>> +&cpu_l3 {
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>> +};
>> +
>> +&gpu {
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>> };
>> &cpu_alert0 {
>>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
2021-11-24 16:41 ` Daniel Lezcano
@ 2021-11-24 16:52 ` Heiko Stübner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2021-11-24 16:52 UTC (permalink / raw)
To: Robin Murphy, Daniel Lezcano
Cc: robh, arnd, ulf.hansson, rjw, devicetree, linux-kernel, linux-pm,
lukasz.luba, Rob Herring, Johan Jonker,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
Am Mittwoch, 24. November 2021, 17:41:34 CET schrieb Daniel Lezcano:
> On 24/11/2021 14:49, Robin Murphy wrote:
> > On 2021-11-24 12:55, Daniel Lezcano wrote:
> >> Add the powerzones description. This first step introduces the big,
> >> the little and the gpu as a powerzone place.
> >
> > These look more like SoC-level properties than board-level ones - should
> > they be in rk3399.dtsi?
>
> Yes, it makes sense
>
> If Heiko is fine with that I can add this description in the rk3399.dtsi
> file
Sure. Robin's suggestion sounds very sensible as these properties are
quite specific to the soc itself.
Heiko
>
> >> ---
> >> .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++
> >> 1 file changed, 45 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> index 1a23e8f3cdf6..83540bdb64cd 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> @@ -61,6 +61,51 @@ bt_active_led: led-6 {
> >> };
> >> };
> >> + powerzones {
> >> +
> >> + PKG_PZ: pkg {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&SOC_PZ>;
> >> + };
> >> +
> >> + SOC_PZ: soc {
> >> + };
> >> + };
> >> +};
> >> +
> >> +&cpu_b0 {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_b1 {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l0 {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l1 {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l2 {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l3 {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&gpu {
> >> + #powerzone-cells = <0>;
> >> + powerzone = <&PKG_PZ>;
> >> };
> >> &cpu_alert0 {
> >>
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-24 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211124125506.2971069-1-daniel.lezcano@linaro.org>
2021-11-24 12:55 ` [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960 Daniel Lezcano
2021-11-24 13:49 ` Robin Murphy
2021-11-24 16:41 ` Daniel Lezcano
2021-11-24 16:52 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).