From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10DA0C433F5 for ; Wed, 24 Nov 2021 16:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UHQA2NABy2d6dG3vYXawRGdDRhQlNnqVrWLqbKGcX8c=; b=S/5R7cvSw9t+zN sxcJJiS2FUemO4BN8Yk2amuRzRFWjhBTqJ1QA8ziq9L69DL1xPS+K5t1KakkpRNPkczfVnTecJajT R9fmfBf8ImG789VdELMXT/jydbcysHcByjnWZ8rvcv7lZ+h3KUYN9FYyN00SpPVuO6UDBeFc4euMC cuU6c5S3eIpiz9CLD5PBEOG7CcF6r410QTx5f9moZ44xeLXQw6PpvYMbn1vA5Yz7+O+cYHHQS7IyX du9ox7/gtpHpQzxZKY6q9l4UllIl0sAIZUnMHxfWQAtYfJOXXKmpGJRtydFU0cePdn+cDGKg3C5cJ nIIeK625PvySkxMPIoHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvVR-005KqQ-LG; Wed, 24 Nov 2021 16:52:25 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvVN-005Kp6-Ow; Wed, 24 Nov 2021 16:52:23 +0000 Received: from ip5f5b2004.dynamic.kabel-deutschland.de ([95.91.32.4] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpvVH-0006PD-AE; Wed, 24 Nov 2021 17:52:15 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Robin Murphy , Daniel Lezcano Cc: robh@kernel.org, arnd@linaro.org, ulf.hansson@linaro.org, rjw@rjwysocki.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, lukasz.luba@arm.com, Rob Herring , Johan Jonker , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" Subject: Re: [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960 Date: Wed, 24 Nov 2021 17:52:14 +0100 Message-ID: <2457824.5MrYSl4YA0@diego> In-Reply-To: References: <20211124125506.2971069-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_085221_861141_D140BF4F X-CRM114-Status: GOOD ( 21.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 24. November 2021, 17:41:34 CET schrieb Daniel Lezcano: > On 24/11/2021 14:49, Robin Murphy wrote: > > On 2021-11-24 12:55, Daniel Lezcano wrote: > >> Add the powerzones description. This first step introduces the big, > >> the little and the gpu as a powerzone place. > > > > These look more like SoC-level properties than board-level ones - should > > they be in rk3399.dtsi? > > Yes, it makes sense > > If Heiko is fine with that I can add this description in the rk3399.dtsi > file Sure. Robin's suggestion sounds very sensible as these properties are quite specific to the soc itself. Heiko > > >> --- > >> .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++ > >> 1 file changed, 45 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> index 1a23e8f3cdf6..83540bdb64cd 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> @@ -61,6 +61,51 @@ bt_active_led: led-6 { > >> }; > >> }; > >> + powerzones { > >> + > >> + PKG_PZ: pkg { > >> + #powerzone-cells = <0>; > >> + powerzone = <&SOC_PZ>; > >> + }; > >> + > >> + SOC_PZ: soc { > >> + }; > >> + }; > >> +}; > >> + > >> +&cpu_b0 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_b1 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l0 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l1 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l2 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l3 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&gpu { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> }; > >> &cpu_alert0 { > >> > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel