From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/2] dtb: xgene: fix: Disable 10GbE and SGMII based 1GbE by default
Date: Tue, 04 Nov 2014 10:40:18 +0100 [thread overview]
Message-ID: <2461768.hHqNmTQE9x@wuerfel> (raw)
In-Reply-To: <CAKh23FkVrPdCuR6dn1S4RvW14_f4Xq8MWaChUh9DyVp44kVtSg@mail.gmail.com>
On Monday 03 November 2014 11:45:44 Iyappan Subramanian wrote:
>
> On Thu, Oct 30, 2014 at 3:13 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday 29 October 2014 17:56:19 Iyappan Subramanian wrote:
> >> @@ -621,7 +621,7 @@
> >> };
> >> };
> >>
> >> - sgenet0: ethernet at 1f210000 {
> >> + sgenet0: sgenet at 1f210000 {
> >> compatible = "apm,xgene-enet";
> >> status = "disabled";
> >> reg = <0x0 0x1f210000 0x0 0x10000>,
> >>
> >
> > This looks like you accidentally reverted a bug fix made earlier.
> > Network devices should always have the name 'ethernet at ...'.
>
> Thanks for the review. Since our firmware was patching the dtb, based
> on the node-name, we thought by changing node-name, we can avoid the
> patching and maintain backward compatibility.
>
> Now we know that network devices should have 'ethernet at ...', we will
> handle the backward compatibility in a different way and will post the
> patch v2 shortly.
It's not important enough to break backwards compatibility over this.
If you can't find a better way to handle compatibility with the old
firmware, just add a comment explaining the node name.
Arnd
next prev parent reply other threads:[~2014-11-04 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 0:56 [PATCH v1 0/2] drivers: net: xgene: Fix crash for backward compatibility Iyappan Subramanian
2014-10-30 0:56 ` [PATCH v1 1/2] dtb: xgene: fix: Disable 10GbE and SGMII based 1GbE by default Iyappan Subramanian
2014-10-30 10:13 ` Arnd Bergmann
2014-11-03 19:45 ` Iyappan Subramanian
2014-11-04 9:40 ` Arnd Bergmann [this message]
2014-10-30 0:56 ` [PATCH v1 2/2] drivers: net: xgene: fix: Use separate resources Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2461768.hHqNmTQE9x@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox