Re: [PATCH 2/4] arm64: dts: rockchip: Remove cap-sd-highspeed on Rock Pi S eMMC

[Shawn Lin <shawn.lin@rock-chips.com>]

Hi Jonas

在 2026/09/25 星期五 0:02, Jonas Karlman 写道:
> Hi,
> 
> On 9/23/2026 9:11 AM, Shawn Lin wrote:
>> cap-sd-highspeed declares SD high-speed support and has no place on
>> the non-removable eMMC node. Drop it.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>>   arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
>> index c1e3098..677d129 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
>> @@ -133,7 +133,6 @@
>>   
>>   &emmc {
>>   	cap-mmc-highspeed;
>> -	cap-sd-highspeed;
> 
> The Rock Pi S board has two similar revisions that is supported by this
> DT, one has onboard SD NAND Flash and the other one has onboard eMMC
> supported by the emmc dw-mshc.
> 
> So this board should have both cap-mmc-highspeed and cap-sd-highspeed
> here to support best speed depending on board revision.

I didn't know about the board revision, so please ignore patch 2/4.

Thanks.

> 
> Regards,
> Jonas
> 
>>   	no-sdio;
>>   	non-removable;
>>   	pinctrl-names = "default";
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>