From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: EXYNOS: Add CMU virtual addresses for exynos5260
Date: Wed, 18 Dec 2013 17:37:23 +0100 [thread overview]
Message-ID: <2468420.340ZhVlqCl@amdc1227> (raw)
In-Reply-To: <1386758416-31065-3-git-send-email-vikas.sajjan@linaro.org>
Hi Vikas, Young-Gun,
On Wednesday 11 of December 2013 16:25:16 Vikas Sajjan wrote:
> From: Young-Gun Jang <yg1004.jang@samsung.com>
>
> Adds CMU virtual addresses for exynos5260.
>
> Change-Id: Ia4f4eda96187d8d9e1edfc1a6b025af56d3bc43e
This line should be dropped.
> Signed-off-by: Young-Gun Jang <yg1004.jang@samsung.com>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
> ---
> arch/arm/mach-exynos/common.c | 65 ++++++++++++++++++++++++++
> arch/arm/mach-exynos/include/mach/map.h | 14 ++++++
> arch/arm/mach-exynos/include/mach/regs-clock.h | 17 +++++++
> arch/arm/plat-samsung/include/plat/map-s5p.h | 16 +++++++
> 4 files changed, 112 insertions(+)
Why do you need those static mappings? Unless there is a reason to map
those registers very early (before ioremap() and friends are available)
I'm going to NAK any additions of static mappings.
Best regards,
Tomasz
prev parent reply other threads:[~2013-12-18 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 10:40 [PATCH 0/2] Add initial support of PMU and CMU for exynos5260 Vikas Sajjan
2013-12-11 10:40 ` [PATCH 1/2] ARM: EXYNOS: Add initial support of PMU for Exynos5260 Vikas Sajjan
2013-12-18 16:35 ` Tomasz Figa
2013-12-31 6:06 ` Vikas Sajjan
2013-12-11 10:40 ` [PATCH 2/2] ARM: EXYNOS: Add CMU virtual addresses for exynos5260 Vikas Sajjan
2013-12-18 16:37 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2468420.340ZhVlqCl@amdc1227 \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox