From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD3C9C433E4 for ; Tue, 28 Jul 2020 08:51:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F04320809 for ; Tue, 28 Jul 2020 08:51:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y8itGaG6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F04320809 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arri.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w1Soe+aNfTdklLZP46m/d0sSYzqGxR6pSBj8uCK5leo=; b=Y8itGaG6eFbUPRwBZP7sp3uAW Zy/Tw+hlQ1PBSIhWS/ZhoOHeHKMlhQsLXVu9o0RagCu6RGIyWZj9iGivXpMsvcjWe3J8/QpCfipSi WEokG1X5eC/oyAHx7iHtJGbH4GTXlbUBfH4CpBjcfYN8QFgQl/N3xO7ViuEbEiJA9aiTU04OwbbRE WjGTodMI4m3VHK3X1cIvYS5fosQ7L+RBj77mIkJqWZexcGEScDd0cGvwwONbcHBOf0pOV+i5DVg4k rV5M552//NmgOl0lZFWCRBWq3Owqu27sgm1YnWuurrozkemPPR17BMvhZrZaIz7D+aAvJDliosJut U8e4yEN+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0LJf-0002fP-6a; Tue, 28 Jul 2020 08:50:31 +0000 Received: from mailout10.rmx.de ([94.199.88.75]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0LJb-0002ej-8P for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 08:50:29 +0000 Received: from kdin01.retarus.com (kdin01.dmz1.retloc [172.19.17.48]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout10.rmx.de (Postfix) with ESMTPS id 4BG9Ns6mg5z37rL; Tue, 28 Jul 2020 10:50:21 +0200 (CEST) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin01.retarus.com (Postfix) with ESMTPS id 4BG9NT21J9z2xjv; Tue, 28 Jul 2020 10:50:01 +0200 (CEST) Received: from n95hx1g2.localnet (192.168.54.10) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 Jul 2020 10:47:31 +0200 From: Christian Eggers To: Marco Felsch Subject: Re: [PATCH] hwrng: imx-rngc - setup default RNG quality Date: Tue, 28 Jul 2020 10:47:29 +0200 Message-ID: <2473540.1Sv8tvBx5K@n95hx1g2> Organization: Arnold & Richter Cine Technik GmbH & Co. Betriebs KG In-Reply-To: <20200728074817.hlevn7ex2hckdbvi@pengutronix.de> References: <20200727124552.4336-1-ceggers@arri.de> <20200728074817.hlevn7ex2hckdbvi@pengutronix.de> MIME-Version: 1.0 X-Originating-IP: [192.168.54.10] X-RMX-ID: 20200728-105003-4BG9NT21J9z2xjv-0@kdin01 X-RMX-SOURCE: 217.111.95.66 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_045028_234407_C7DE06E0 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Arnd Bergmann , Martin Kaiser , Sascha Hauer , Matt Mackall , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Greg Kroah-Hartman , Shawn Guo , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco, On Tuesday, 28 July 2020, 09:48:17 CEST, Marco Felsch wrote: > Hi Christian, > > On 20-07-27 14:45, Christian Eggers wrote: > > When hw_random device's quality is non-zero, it will automatically fill > > the kernel's entropy pool at boot. For this purpose, one conservative > > quality value is being picked up as the default value. > > IMHO your value is not conservative enough and the commit message should > explain why we should use 900. Unfortunately I had not enough time to > send my patch addressing this. However please check my commit message > why 900 is not good: ok, you caught me. I found the value of 900 in several other drivers and simply took it. Even parts of my commit message were simply copied... As I have no real idea about determining the right quality, I will leave this task for you :-) Thanks Christian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel