From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D5EC4338F for ; Sun, 22 Aug 2021 20:27:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EF6B61242 for ; Sun, 22 Aug 2021 20:27:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4EF6B61242 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AE/G+9JAVKPNS7rr/FSlWHUZsrKg3yjfxgSku2innjQ=; b=MzSx/BZbaTI1D/ dwUIAlE0bKdq33TvM78hfif1Kkb2VCOqfEN+zKh++2KUqqu5Haci5jrrwqMJ/0kbMTioATE1X0CVb diKPXqci8ppC0mc/jUbSmMn8tBPN4hKGjBLLXCb6qXlvI295ZOKH9JNNUJfCBmRSqBIpScDTEGsjd y9RvJ6DFOh8RWN+THsxAWi41go0piGqHQgl18OBqAangw915ZIvlw84pqdvmejS4aUZbMP1r8nZ+H W86PDp1wfb4yaGFVeZ2khn357eQ3d4++YzLiXDNCGbiAFAsnpucwfCpZev5kMCicZ+yljLiJ9il/m QljgKb1Vk+SmeaYtvljA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHu2L-00Ei5t-V7; Sun, 22 Aug 2021 20:25:46 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHu2I-00Ei5F-PQ; Sun, 22 Aug 2021 20:25:44 +0000 Received: from p5b036204.dip0.t-ipconnect.de ([91.3.98.4] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHu2E-0005lA-2D; Sun, 22 Aug 2021 22:25:38 +0200 From: Heiko Stuebner To: Alex Bee , Ezequiel Garcia Cc: Rob Herring , Johan Jonker , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List Subject: Re: [PATCH] arm64: dts: rockchip: Re-add interrupt-names for RK3399's vpu Date: Sun, 22 Aug 2021 22:25:36 +0200 Message-ID: <24767661.6Emhk5qWAg@phil> In-Reply-To: References: <20210822115755.3171937-1-knaerzche@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210822_132542_884027_802B712D X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Sonntag, 22. August 2021, 16:37:24 CEST schrieb Ezequiel Garcia: > Hi Alex, Heiko, > > On Sun, 22 Aug 2021 at 08:58, Alex Bee wrote: > > > > Commit a728c10dd62a ("arm64: dts: rockchip: remove interrupt-names from iommu nodes") > > intended to remove the interrupt-names property for mmu nodes, but it > > also removed it for the vpu node in rk3399.dtsi. That makes the driver > > fail probing currently. > > Fix this by re-adding the property for this node. > > > > Fixes: a728c10dd62a ("arm64: dts: rockchip: remove interrupt-names from iommu nodes") > > AFAICS a728c10dd62a removed lots of interrupt-names properties > from devices other than IOMMU. > > Maybe it's best to revert it? where did you see more mistakes in it? I.e. first of all, at least when grepping through my kernel history, I only see commit 53a05c8f6e8e ("arm64: dts: rockchip: remove interrupt-names from iommu nodes") with a different hash and at least there I see a lot of iommu interrupt removals and this one line removing the vpu irqs in error. So from my glance at it, applying Alex' patch should solve the issue? Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel