From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B360BC433E0 for ; Fri, 5 Jun 2020 17:26:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8747E206F0 for ; Fri, 5 Jun 2020 17:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hoba7Odt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8747E206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xf6iECEUkeqqTRurTQ5iPwxLtp5y5k2dKFGn/gDnTaU=; b=Hoba7OdtwmHUtH YhrKzzKb9hFhoagaOkfk9R0JJi/eOCztZQvrsf0xujUicg1kbtJi0siAP0tMFuEvDgyZVeusVTZB9 mVoOe7twRwunFEQc65oI2VwDFoPToZpFldJe3hukUqjrSOnhOZOINpelVIw4+H9lqsiKQ2GrjgOGy T1TKUz0abYcKa7MERdBm0xX37H+lvg5sYi5A2BD7c8MFrfaUDdy7E5QE7rfLqM7gVmNw0Ce5JF4td HGOgcdrKMApdzsZYEKciQNecxzv/VDMl7+oVNZ1v99cnwkgdbn2k3ih+2u3l4YaiBRoDHJJcNajsq pwfU+NghbEaJyO2AZemA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhG71-00013s-0G; Fri, 05 Jun 2020 17:26:35 +0000 Received: from mailoutvs39.siol.net ([185.57.226.230] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhG6x-00011z-OH for linux-arm-kernel@lists.infradead.org; Fri, 05 Jun 2020 17:26:33 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 33D78521D26; Fri, 5 Jun 2020 19:26:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Hkdlf3xJ94FU; Fri, 5 Jun 2020 19:26:21 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id C0F03521D2D; Fri, 5 Jun 2020 19:26:21 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-194-152-20-232.static.triera.net [194.152.20.232]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id C2B65521CA7; Fri, 5 Jun 2020 19:26:20 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: paul.kocialkowski@bootlin.com, mripard@kernel.org, Nicolas Dufresne Subject: Re: [PATCH 2/3] media: cedrus: h264: Properly configure reference field Date: Fri, 05 Jun 2020 19:26:20 +0200 Message-ID: <2479507.UA2pHCgT9S@jernej-laptop> In-Reply-To: <7e74e15b7b3f9fc765182f1a43cfcf1e0e9602fc.camel@ndufresne.ca> References: <20200604185745.23568-1-jernej.skrabec@siol.net> <20200604185745.23568-3-jernej.skrabec@siol.net> <7e74e15b7b3f9fc765182f1a43cfcf1e0e9602fc.camel@ndufresne.ca> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_102631_944460_C98CDED0 X-CRM114-Status: GOOD ( 12.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, jonas@kwiboo.se, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, wens@csie.org, hverkuil-cisco@xs4all.nl, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 05. junij 2020 ob 19:16:35 CEST je Nicolas Dufresne napisal(a): > Le jeudi 04 juin 2020 =E0 20:57 +0200, Jernej Skrabec a =E9crit : > > When interlaced H264 content is being decoded, references must indicate > > which field is being referenced. Currently this was done by checking > > capture buffer flags. However, that is not correct because capture > > buffer may hold both fields. > > = > > Fix this by checking newly introduced flags in reference lists. > > = > > Signed-off-by: Jernej Skrabec > = > Perhaps an additional patch could cleanup the miss-leading comment in > v4l2_h264_dpb_entry definition. I missed that. I think this change actually belongs to patch 1. I'll fix it= in = v2. Best regards, Jernej > = > Reviewed-by: Nicolas Dufresne > = > > --- > > = > > drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > = > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c > > b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c index > > cce527bbdf86..c87717d17ec5 100644 > > --- a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c > > @@ -183,7 +183,6 @@ static void _cedrus_write_ref_list(struct cedrus_ctx > > *ctx,> = > > for (i =3D 0; i < num_ref; i++) { > > = > > const struct v4l2_h264_dpb_entry *dpb; > > const struct cedrus_buffer *cedrus_buf; > > = > > - const struct vb2_v4l2_buffer *ref_buf; > > = > > unsigned int position; > > int buf_idx; > > u8 dpb_idx; > > = > > @@ -198,12 +197,11 @@ static void _cedrus_write_ref_list(struct cedrus_= ctx > > *ctx,> = > > if (buf_idx < 0) > > = > > continue; > > = > > - ref_buf =3D to_vb2_v4l2_buffer(cap_q->bufs[buf_idx]); > > - cedrus_buf =3D vb2_v4l2_to_cedrus_buffer(ref_buf); > > + cedrus_buf =3D vb2_to_cedrus_buffer(cap_q->bufs[buf_idx]); > > = > > position =3D cedrus_buf->codec.h264.position; > > = > > sram_array[i] |=3D position << 1; > > = > > - if (ref_buf->field =3D=3D V4L2_FIELD_BOTTOM) > > + if (ref_list[i].flags & = V4L2_H264_REFERENCE_FLAG_BOTTOM_FIELD) > > = > > sram_array[i] |=3D BIT(0); > > = > > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel