From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32374C4363A for ; Sun, 25 Oct 2020 07:32:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA6722080A for ; Sun, 25 Oct 2020 07:32:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aL7Lcfgy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA6722080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6BRhfrrPBh1KnQGNBDqrS+PvNsMCrKAEdYtX1IomLqQ=; b=aL7LcfgyaBbfRj8KMQ9CEpKB6 tD5GxtnPORKRNGiPVc83IlG3m+HZy5N8pSCaJckLSgUEm2AQ70gSURnYd8LwmnMpSxtMBxBDHnuS9 qlQildT42AziGwB0qbA35vsieX21orCIGudJR2v9Hf9SKuF/fGzBp56sikYAw91n5T9uiiRkeJcFp ybu4Td6W9fZ3l1q1Jzg5D8HF/g4KmpN7rRf2ciPQdoOQFDMDmCz3d6LBfaWD9H5RhloKUcIN/hRBE WI6kcftMHbqqEsNhgAQxMF/0KCJ5DD2S20zNSaULInHzn5KlRIkRAa0tz9pHC6V3wMaC2x/3DmQCg Tkr95ewnQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWaTX-0008Uh-F0; Sun, 25 Oct 2020 07:29:59 +0000 Received: from mailoutvs17.siol.net ([185.57.226.208] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWaTT-0008UM-S8 for linux-arm-kernel@lists.infradead.org; Sun, 25 Oct 2020 07:29:57 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id E50DB524901; Sun, 25 Oct 2020 08:29:51 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UNIJcn0pZV9N; Sun, 25 Oct 2020 08:29:51 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id A174752352F; Sun, 25 Oct 2020 08:29:51 +0100 (CET) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 11403524901; Sun, 25 Oct 2020 08:29:50 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai Subject: Re: [PATCH 01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" Date: Sun, 25 Oct 2020 08:35:20 +0100 Message-ID: <2494995.jnrXR15XKO@kista> In-Reply-To: <20201024162515.30032-1-wens@kernel.org> References: <20201024162515.30032-1-wens@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201025_032956_127235_A9D962CA X-CRM114-Status: GOOD ( 11.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sobota, 24. oktober 2020 ob 18:25:06 CET je Chen-Yu Tsai napisal(a): > From: Chen-Yu Tsai > > This reverts commit 75ee680cbd2e4d0156b94f9fec50076361ab12f2. > > Turns out the activity and link LEDs on the RJ45 port are active low, > just like on the Orange Pi PC. > > Revert the commit that says otherwise. > > Fixes: 75ee680cbd2e ("arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high") > Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)") > Signed-off-by: Chen-Yu Tsai > --- > If you have this board, please help test it. > > For me, the correct lighting of the LEDs is both LEDs should be lit > when connected at 100 Mbps. Tested-by: Jernej Skrabec Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel