linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/8] Introduce automatic DMA configuration for IOMMU masters
Date: Mon, 01 Dec 2014 14:52:57 +0100	[thread overview]
Message-ID: <2496335.D95hVHbola@wuerfel> (raw)
In-Reply-To: <1417181386-18142-1-git-send-email-will.deacon@arm.com>

On Friday 28 November 2014 13:29:38 Will Deacon wrote:
> Hi all,
> 
> Here is v5 of the patches I've previously sent here:
> 
>   RFCv1: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/283023.html
>   RFCv2: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/283752.html
>   RFCv3: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/287031.html
>   RFCv4: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/302711.html
> 
> Changes since RFCv4 include:
> 
>   - Dropped the RFC tag, since has been used by a couple of people now
> 
>   - Dropped the DMA segment configuration from of_dma_configure, as there
>     appear to be assumptions about 64k segments elsewhere in the kernel
> 
>   - Added acks/tested-bys (thanks to everybody who reviewed the series)
> 
>   - A few small fixes for issues found by Marek
> 
> Arnd: Is this too late for 3.19? We could merge the first 6 patches
> with no issues, since there aren't any callers of of_iommu_init
> without patch 7 anyway.
> 
> Up to you.

I think this looks great overall. My only feedback is the exact same
comment that Joerg already made:

On Friday 28 November 2014 14:03:36 jroedel at suse.de wrote:
> Hmm, I don't like the idea of storing private data in iommu_ops. But
> given that this is already an improvement we can build on later, here is
> my
> 
>         Acked-by: Joerg Roedel <jroedel@suse.de>
> 
> To further improve this we should probably introduce a seperate
> iommu-descriptor data-structure later which then describes a single
> hardware iommu device.

so I second that and add my

Acked-by: Arnd Bergmann <arnd@arndb.de>

Now, who should merge this series? I think someone should put all eight
patches into linux-next now, and if something goes wrong with the last
two, then we skip them for 3.19.

	Arnd

  parent reply	other threads:[~2014-12-01 13:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 13:29 [PATCH v5 0/8] Introduce automatic DMA configuration for IOMMU masters Will Deacon
2014-11-28 13:29 ` [PATCH v5 1/8] iommu: provide early initialisation hook for IOMMU drivers Will Deacon
2014-11-28 13:29 ` [PATCH v5 2/8] dma-mapping: replace set_arch_dma_coherent_ops with arch_setup_dma_ops Will Deacon
2014-11-28 13:29 ` [PATCH v5 3/8] iommu: add new iommu_ops callback for adding an OF device Will Deacon
2014-11-28 13:29 ` [PATCH v5 4/8] iommu: provide helper function to configure an IOMMU for an of master Will Deacon
2014-11-28 13:29 ` [PATCH v5 5/8] iommu: fix initialization without 'add_device' callback Will Deacon
2014-11-28 13:29 ` [PATCH v5 6/8] dma-mapping: detect and configure IOMMU in of_dma_configure Will Deacon
2014-11-28 13:29 ` [PATCH v5 7/8] arm: call iommu_init before of_platform_populate Will Deacon
2014-11-28 13:29 ` [PATCH v5 8/8] arm: dma-mapping: plumb our iommu mapping ops into arch_setup_dma_ops Will Deacon
2014-12-01 13:52 ` Arnd Bergmann [this message]
2014-12-01 15:05   ` [PATCH v5 0/8] Introduce automatic DMA configuration for IOMMU masters Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2496335.D95hVHbola@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).