From: "Heiko Stübner" <heiko@sntech.de>
To: Iskander Amara <iskander.amara@theobroma-systems.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, vahe.grigoryan@theobroma-systems.com,
angelogioacchino.delregno@collabora.com, dsimic@manjaro.org,
alexander.stein@ew.tq-group.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Quentin Schulz <quentin.schulz@theobroma-systems.com>
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 Puma
Date: Fri, 08 Mar 2024 10:29:41 +0100 [thread overview]
Message-ID: <24965019.EfDdHjke4D@diego> (raw)
In-Reply-To: <ffc940bf-b9df-4731-a34d-f725a6d6d7f1@theobroma-systems.com>
Am Freitag, 8. März 2024, 10:25:43 CET schrieb Quentin Schulz:
> Hi Iskander,
>
> On 3/8/24 09:52, Iskander Amara wrote:
> > Q7_THRM# pin is connected to a diode on the module which is used
> > as a level shifter, and the pin have a pull-down enabled by
> > default. We need to configure it to internal pull-up, other-
> > wise whenever the pin is configured as INPUT and we try to
> > control it externally the value will always remain zero.
> >
> > Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com>
>
> For the whole series:
>
> Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> @Heiko I think this may match the criteria for stable backports?
at least patch1 does ... it definitly should have a Fixes tag though.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-08 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:52 [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 Puma Iskander Amara
2024-03-08 8:52 ` [PATCH 2/2] arm64: dts: rockchip: fix alphabetical ordering RK3399 puma Iskander Amara
2024-03-08 9:25 ` [PATCH 1/2] arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 Puma Quentin Schulz
2024-03-08 9:29 ` Heiko Stübner [this message]
2024-03-08 9:33 ` Quentin Schulz
2024-03-24 22:38 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24965019.EfDdHjke4D@diego \
--to=heiko@sntech.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=iskander.amara@theobroma-systems.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=vahe.grigoryan@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox