From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68E00E7717D for ; Fri, 13 Dec 2024 11:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TOvdrY6ZK03lS7952dPZDMgLr1EpXZjEA+isc/DBTlo=; b=mfkbMAe+pf0fky6Fsc44nDuW0X X2iUIiD7EmaOyYtdPXbLvA/mZA/f+CWnmS3gFT7HaOSo9dGs9Q546MXhWHkJ7SHaP0F7FUzYx6Do7 bH0weqJgtiUDMXdAMJUMu6k2gZN7igR4oLFr3lT3miY6ycsXfy0F4jM4hH/Cvn5Q1B8iobt/suO+5 41JYpx+BRkIKZC/0ppkzy5mqviyf9hA7Ql51XsUXtoYx0ICNijOpZ/07mQfWzkwdfeN5zv3vz2bFJ KoQ3Y620ZA+qBcry/MP80sQDZ2aJVfJUskhUxgppqzbQv8DUYiZCvsIS4Mtmq91SPuSz2wKAcjWrp R7C1Z3mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tM3pu-00000003YiA-01vf; Fri, 13 Dec 2024 11:27:58 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tM3oH-00000003YMq-0NSX for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2024 11:26:19 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BDAwCCD007389; Fri, 13 Dec 2024 12:25:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= TOvdrY6ZK03lS7952dPZDMgLr1EpXZjEA+isc/DBTlo=; b=nX0aIA0N2vd095Qk zjlywg33Qq22QUrLPcu5++yxKf46EcwbgwN8HJ0/F03UGwTT1i+veXljzaaJWbUY TA1scFnKyf9MNCwLmFVlj8lwEgzhRiQjN2Q+++pihvqhkFKSYz6pU7syKvTZ0Tq2 1IL4rHx3eC9/hwJkFTC88vKXuxezG9Iro9d2s8fmbCu7GrDrDrUusWwK40T7z5+L pjgFZKdipnq1wGlg5Xeos2S4eoC/aZSM7/5NUko6mVe+vbCTPoJ0it0hK+RpVPel 2W+LoK244qN08XMGNIWBg+mXZxuRnZ8b3cdTlrkj2iXDQbMkw1xOhMI3Kdj85QhB J+xA7Q== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 43ffwc82gr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Dec 2024 12:25:58 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 0A4F54004A; Fri, 13 Dec 2024 12:25:03 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D0AC425B04F; Fri, 13 Dec 2024 12:24:30 +0100 (CET) Received: from SHFDAG1NODE1.st.com (10.75.129.69) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Fri, 13 Dec 2024 12:24:30 +0100 Received: from SHFDAG1NODE1.st.com ([fe80::b848:dbeb:cd0:84a0]) by SHFDAG1NODE1.st.com ([fe80::b848:dbeb:cd0:84a0%13]) with mapi id 15.01.2507.037; Fri, 13 Dec 2024 12:24:30 +0100 From: Etienne CARRIERE - foss To: Sudeep Holla CC: "linux-kernel@vger.kernel.org" , "Cristian Marussi" , Michael Turquette , Stephen Boyd , "arm-scmi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v2 2/2] firmware: arm_scmi: round rate bisecting in discrete rates Thread-Topic: [PATCH v2 2/2] firmware: arm_scmi: round rate bisecting in discrete rates Thread-Index: AQHbRapDtK1zP5F5+E+8H5T6eqOTIbLdsy4AgAAr30uAAD/MAIABMogogASvjhk= Date: Fri, 13 Dec 2024 11:24:30 +0000 Message-ID: <24d1fce2660a4d8296dd7c699020932a@foss.st.com> References: <20241203173908.3148794-1-etienne.carriere@foss.st.com> <20241203173908.3148794-3-etienne.carriere@foss.st.com> ,, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.30.176] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241213_032617_425602_7F885EEE X-CRM114-Status: GOOD ( 23.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday, December 10, 2024, Etienne CARRIERE - foss wrote: > On Monday, December 9, 2024, Sudeep Holla wrote: > > On Mon, Dec 09, 2024 at 12:59:58PM +0000, Etienne CARRIERE - foss wrote= : > (...) > > > > I would like to avoid this extra query if not required which you se= em to > > > > have made an attempt but I just want to be thorough and make sure t= hat's > > > > what we need w.r.t the specification. > > > > > > Sure, I indeed prefer clear and robust implementation in the long ter= m, > > > being the one I propose here or another one. > > > > > > > Good then, we can work towards achieving that. If you can specify how s= low > > or memory hungry is it without these changes and how much this change h= elps > > your platform, we can take it up with spec authors and see if they are = happy > > to provide some alternative to deal with this in a generic way. >=20 > The platforms we target usually have plenty of RAM, lets say hundreds of = MBytes. > Not that much for some system but enough I guess to store a few hundreds = of > clock rates for a few dozen of clocks (few kByte of RAM). During last SCMI monthly meeting [1], there was a suggestion to use a lazy query of the full clock discrete rates list: the first time clk_round_rate(= ) is requested on an SCMI clock with discrete rates, we can allocated and get the full rate list once in struct scmi_clock_info. It will be ease to local= ly bisect or scan into these supported rates for clk_round_rate() operations. It would prevent to store the full discrete rates list for all SCMI clocks = when clk_round_rate() is queried only for a very few of them. Do you think it would be a good compromise?=20 [1] https://linaro.atlassian.net/wiki/spaces/SCMI/overview#Meetings BR, Etienne >=20 > That said, thinking more and more about this, I really belive a dedicate = SCMI > clock protocol command would better fit platform needs in the long term. >=20 > BR, > Etienne >=20 > > > > -- > > Regards, > > Sudeep > > >=20