From: Radu Rendec <radu@rendec.net>
To: Kemeng Shi <shikemeng@huaweicloud.com>,
maz@kernel.org, tglx@kernel.org, jason@lakedaemon.net,
lpieralisi@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] irqchip/gic-v3-its: Fix memleak in its_probe_one()
Date: Sat, 04 Jul 2026 10:51:09 -0400 [thread overview]
Message-ID: <24de1fda7ed76615b2c24fe0352b5b1cb35038d6.camel@rendec.net> (raw)
In-Reply-To: <20260702033050.1583-2-shikemeng@huaweicloud.com>
On Thu, 2026-07-02 at 11:30 +0800, Kemeng Shi wrote:
> Fix collection leak when its_init_domain() failed in its_probe_one().
>
> Fixes: 4c21f3c26ecc2 ("irqchip: GICv3: ITS: DT probing and initialization")
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 291d7668cc8d..d721b6101e0a 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -5326,7 +5326,7 @@ static int __init its_probe_one(struct its_node *its)
>
> err = its_init_domain(its);
> if (err)
> - goto out_free_tables;
> + goto out_free_col;
>
> raw_spin_lock(&its_lock);
> list_add(&its->entry, &its_nodes);
> @@ -5334,6 +5334,8 @@ static int __init its_probe_one(struct its_node *its)
>
> return 0;
>
> +out_free_col:
> + kfree(its->collections);
> out_free_tables:
> its_free_tables(its);
> out_free_cmd:
Reviewed-by: Radu Rendec <radu@rendec.net>
next prev parent reply other threads:[~2026-07-04 14:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 3:30 [PATCH v4 0/6] Some Minor fixes and cleanups to irqchip/gic-v3-its Kemeng Shi
2026-07-02 3:30 ` [PATCH v4 1/6] irqchip/gic-v3-its: Fix memleak in its_probe_one() Kemeng Shi
2026-07-04 14:51 ` Radu Rendec [this message]
2026-07-02 3:30 ` [PATCH v4 2/6] irqchip/gic-v3-its: Fix its node leak in gic_acpi_parse_madt_its() Kemeng Shi
2026-07-04 15:08 ` Radu Rendec
2026-07-02 3:30 ` [PATCH v4 3/6] irqchip/gic-v3-its: Fix leak in its_vpe_irq_domain_alloc() Kemeng Shi
2026-07-02 22:12 ` Marc Zyngier
2026-07-03 1:44 ` Kemeng Shi
2026-07-02 3:30 ` [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs Kemeng Shi
2026-07-02 22:10 ` Marc Zyngier
2026-07-03 1:45 ` Kemeng Shi
2026-07-02 3:30 ` [PATCH v4 5/6] irqchip/gic-v3-its: Fix grammar and replace a bit number with its symbol Kemeng Shi
2026-07-04 15:37 ` Radu Rendec
2026-07-02 3:30 ` [PATCH v4 6/6] irqchip/gic-v3-its: Remove redundant check in its_vpe_db_proxy_unmap_locked() Kemeng Shi
2026-07-04 16:32 ` Radu Rendec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24de1fda7ed76615b2c24fe0352b5b1cb35038d6.camel@rendec.net \
--to=radu@rendec.net \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox