From: <Conor.Dooley@microchip.com>
To: <sudeep.holla@arm.com>, <Conor.Dooley@microchip.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<palmer@rivosinc.com>, <aou@eecs.berkeley.edu>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<linux@armlinux.org.uk>, <arnd@arndb.de>,
<Daire.McNamara@microchip.com>, <niklas.cassel@wdc.com>,
<damien.lemoal@opensource.wdc.com>, <geert@linux-m68k.org>,
<zong.li@sifive.com>, <kernel@esmil.dk>, <hahnjo@hahnjo.de>,
<guoren@kernel.org>, <anup@brainfault.org>,
<atishp@atishpatra.org>, <heiko@sntech.de>,
<philipp.tomsich@vrull.eu>, <robh@kernel.org>, <maz@kernel.org>,
<viresh.kumar@linaro.org>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <Brice.Goglin@inria.fr>
Subject: Re: [PATCH v2 1/2] arm64: topology: move store_cpu_topology() to shared code
Date: Mon, 11 Jul 2022 10:24:38 +0000 [thread overview]
Message-ID: <24e3d8a0-c998-4a68-af28-57dcf15682ee@microchip.com> (raw)
In-Reply-To: <20220711100204.bj3r3g6xs577kuul@bogus>
On 11/07/2022 11:02, Sudeep Holla wrote:
> On Sat, Jul 09, 2022 at 12:58:57PM +0000, Conor.Dooley@microchip.com wrote:
>> Looking at the arm32 implementation - it appears to be mostly the sort of MPIDR
>> stuff that was removed from the arm64 implementation in 3102bc0e6ac7 ("arm64:
>> topology: Stop using MPIDR for topology information"). Could arm32 benefit from
>> the same shared implemenation too, or is usage of MPIDR only invalid for arm64?
>
> I don't recall all the details but IIRC there are parts if arch_topology
> that are ARM64/RISC-V only. ARM32 doesn't use it as it may break old
> platforms. Some of the functions that still arm32 specific are retained
> in arch/arm
>
>> The other difference is a call to update_cpu_capacity() in the arm32
>> implementation. Could that be moved to smp_store_cpu_info() which is the only
>> callsite of store_cpu_topology()?
>>
>
> No please, leave arm32 as is. It was done for a reason like that and it
> help to not break some of the old 32-by platforms.
Thought that might be the case, I won't (and didn't) touch arm32!
Thanks,
Conor.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-11 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 20:33 [PATCH v2 0/2] Fix RISC-V's arch-topology reporting Conor Dooley
2022-07-08 20:33 ` [PATCH v2 1/2] arm64: topology: move store_cpu_topology() to shared code Conor Dooley
2022-07-08 20:45 ` Conor.Dooley
2022-07-09 12:58 ` Conor.Dooley
2022-07-09 19:50 ` Russell King (Oracle)
2022-07-11 10:02 ` Sudeep Holla
2022-07-11 10:24 ` Conor.Dooley [this message]
2022-07-08 20:33 ` [PATCH v2 2/2] riscv: topology: fix default topology reporting Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e3d8a0-c998-4a68-af28-57dcf15682ee@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Brice.Goglin@inria.fr \
--cc=Daire.McNamara@microchip.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=atishp@atishpatra.org \
--cc=catalin.marinas@arm.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=hahnjo@hahnjo.de \
--cc=heiko@sntech.de \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=philipp.tomsich@vrull.eu \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).