From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1FFDCEF142 for ; Tue, 8 Oct 2024 09:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Az/KMPreXaGl91pZI4523wJ5r8ejn+YnIG+Mof+90Ek=; b=IHOmRVW63sKqgoLzllUpfFSzXD 9aqxBTQ/ALEveiT+K5cg0DCYIW1Z29Do5f2dkwvjyYH5keH5qgxfJ9rjfyr3fpGxuMDAzm2xwiwz4 3hVkoKPpGPAvCtI4YsTk6BrWmN2wF2p+o+JB2fX9zv8ozxNZhhDTK/+Ww+5QATVmR2yTlZG9dXO0X FYp7Zl0tjx3tQ46xIcWVyVGO91VaBvnz0sxAb8/vbdR7n/EFNi1xqyPitmX7mtnjv7snmldvAyVQR XImUGWt4pTFpap5L6JxTwJmA+aVteqEBHKQ0Rh+1OArBaQAXvsvir8RCFqups3i7PSUVGVxs2u9ym ZAiK+UQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy6QY-00000005HHU-3Z0E; Tue, 08 Oct 2024 09:22:46 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy65f-00000005CKn-3kOy for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 09:01:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728378069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Az/KMPreXaGl91pZI4523wJ5r8ejn+YnIG+Mof+90Ek=; b=gLoeG1BDrEOHTotR44qJAmZbKTO2bzCpM5rUzg7R65gpk1wAmEbwohWUVgvpFY8ZLXUFd7 aMmzeNyHn3sWTm6bFUyksUkLBB7MP2lu7dx54nL80UugGcvf95iFFlpC62YkdspDUTa94U jApWD39bOgW2NZL1EPAJd1MzKzw/wC8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-I8CiOknUMUSTQ4nwPpkJzg-1; Tue, 08 Oct 2024 05:01:08 -0400 X-MC-Unique: I8CiOknUMUSTQ4nwPpkJzg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37ce6262705so2742101f8f.1 for ; Tue, 08 Oct 2024 02:01:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728378067; x=1728982867; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Az/KMPreXaGl91pZI4523wJ5r8ejn+YnIG+Mof+90Ek=; b=CY8MNne0oFLUCwKU7w/lTuoR+xAirvNket4JwdmzCbTwjgYaGeEkXny5Pb9ZnBkq2i mFsYhu9V/dgZDci4ntxQCq5I2PCAWVMhx0Dob0k5JdDtvgj3HsnsnLHxuQ/T0ER2leiY lIKLnpcmnJ9uhibHdfQwdTZAC//1AYCFgTkPBUR6OM1bSfgh2lT16yJKbsbgL9438OSX 6LJ1nDfMbLU37SFSvPVJS8medEpOgSTudCh42dZ/PpK6NxjeQg4L126PKt4lNP9nlhyy +z0X60BGiGpCk8uMgpfkcvXqmyuoiEn2qi0b/usffJ+iru9FP6UaJkNwx2o7eLyX9KoO LiLA== X-Forwarded-Encrypted: i=1; AJvYcCUC45BCKho2ejr314weYwsyb2as2Uwd0F71DrHE9URN2EKvQzn13UWtgpfp/KA+DX9kNNFF9ycSTLOmqMYKCmRx@lists.infradead.org X-Gm-Message-State: AOJu0YyAdmLD4Z2FZrGgGUCYOCF29uqERcKHSbQ6wFfuPVYaryiIBje8 BKU10DsGMCUaY9gE7im/pHGqSyCv1XsCaPi4a+op7hJIXsSvsBFoqDrwdn32BYDlhQBBPjVNwvz v5FHD7ETp1QaLVYa7mZX7komp8hMZLyw5x2pFRzzBMNp/Rp6yW6+GLYyrqXjtPb7puOzNyR5+ X-Received: by 2002:a5d:64e7:0:b0:374:c040:b00e with SMTP id ffacd0b85a97d-37d0e7d43c8mr10304859f8f.39.1728378067045; Tue, 08 Oct 2024 02:01:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIFwLBzdlSN+s2luoQEVwbNKJu+jYd1X+INDAyIvF4Y/gn2XGZgzsLbGQxoIp6iqg9MixO4A== X-Received: by 2002:a5d:64e7:0:b0:374:c040:b00e with SMTP id ffacd0b85a97d-37d0e7d43c8mr10304829f8f.39.1728378066670; Tue, 08 Oct 2024 02:01:06 -0700 (PDT) Received: from [192.168.88.248] (146-241-82-174.dyn.eolo.it. [146.241.82.174]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d1691a4d8sm7587775f8f.36.2024.10.08.02.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 02:01:06 -0700 (PDT) Message-ID: <24e50bd4-05e7-48be-b943-b361f4e73fdf@redhat.com> Date: Tue, 8 Oct 2024 11:01:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 08/13] net: pcs: xpcs: use FIELD_PREP() and FIELD_GET() To: "Russell King (Oracle)" , Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jiawen Wu , Jose Abreu , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mengyuan Lou , netdev@vger.kernel.org, Vladimir Oltean References: From: Paolo Abeni In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_020112_107554_751D32AC X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 10/4/24 12:21, Russell King (Oracle) wrote: > diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c > index 805856cabba1..f55bc180c624 100644 > --- a/drivers/net/pcs/pcs-xpcs.c > +++ b/drivers/net/pcs/pcs-xpcs.c > @@ -592,7 +592,8 @@ int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, int enable) > ret = DW_VR_MII_EEE_LTX_EN | DW_VR_MII_EEE_LRX_EN | > DW_VR_MII_EEE_TX_QUIET_EN | DW_VR_MII_EEE_RX_QUIET_EN | > DW_VR_MII_EEE_TX_EN_CTRL | DW_VR_MII_EEE_RX_EN_CTRL | > - mult_fact_100ns << DW_VR_MII_EEE_MULT_FACT_100NS_SHIFT; > + FIELD_PREP(DW_VR_MII_EEE_MULT_FACT_100NS, > + mult_fact_100ns); > } else { > ret &= ~(DW_VR_MII_EEE_LTX_EN | DW_VR_MII_EEE_LRX_EN | > DW_VR_MII_EEE_TX_QUIET_EN | DW_VR_MII_EEE_RX_QUIET_EN | Very minor and non blocking thing: perhaps consider renaming DW_VR_MII_EEE_MULT_FACT_100NS to DW_VR_MII_EEE_MULT_FACT_100NS_MASK - possibly in a later work? Cheers, Paolo