From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3CB7C433B4 for ; Wed, 28 Apr 2021 08:42:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34690613B1 for ; Wed, 28 Apr 2021 08:42:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34690613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZH+fEnJZwMtwxl+eKlpg3toTxgYDQxZeCFrjzaWQG+s=; b=hEcbQcwKXlobzXqgX0vWlcBy2 h3pREHuGOKE21MjL9bv8g6bpuq5xmUsoB9DRoyg62UCm9eIyoVaUiezleagi0yN6RJVy0EMZs24dA EWRvKoAI6gVpPRTGlw+vHkUzy9f7gzB8EATDyVRJQ3gq6BkRQpzPZAAdGT0Fd14YK4vjq7nW7KMd/ vDTFnko3Xim9w+DKmn4/78aDNw0wXuCYFfR0vX4xAf2X8ZV6YVb60lYQ+dGDfLzFchqnqFK3C9mmw 9ERsOusD5khOLB84whREdXEZTyS+C6Fe8xe+wGvFmhikSP00B/mRuVekVQWobD4wIugWpa976omcl MdrevbzjQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbfkm-0038PE-3I; Wed, 28 Apr 2021 08:41:04 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbfki-0038On-Cv for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 08:41:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=oVYoHb0j5VFpSmctH5aR8XGJ4ktZiFaaq0zVF+LId6M=; b=aYaPfeHS/nmcCrRHETsa6HZSoP NZrjIiDpg3Ce9JnLUyYAotI0lAT3RetcCqMwOAoVutGqzNyhvQmsLsYNTXCfwPirlSCxki4vF7niy gKvjXFbqmWh+WMVN/tIY+dJggfkZczR3HS+R/XTi0zDJVH6D5IdCoLDz2QXxQ22w1Ifw06B7CM5+q qiJ1DpOjq0UfCCPuGQfAXY2KP79hWCNwuWThT8G4BXPSGTV+81v+AI0FadK57r6tuhVx668TPsBPt W69OwRynRf+XkemB6jd+AlkvQjY3Vb1FrG5alvITYeWN5kpAmNiJDKs0b1Ja03MzuKHw14LNzk+1k LzxG2DdQ==; Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbfkf-00HI5H-E5 for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 08:40:58 +0000 Received: by mail-lf1-x12a.google.com with SMTP id y4so57679285lfl.10 for ; Wed, 28 Apr 2021 01:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oVYoHb0j5VFpSmctH5aR8XGJ4ktZiFaaq0zVF+LId6M=; b=VmsGeVNhBij6WOHJ1eY4hSlEkPPsps8a7tFi36TLwEKoHl8nZdwE1/LgTd1Zscl3lS l5JyzVZKh4Uoiawv1bs2Qwho0siLbLViBIhfa147ATHN8KIECJHBlDS5zM5F2efuzjg+ 4yXj3IYXKVfY4P61gl5P7cdnbFfqGpd7nYy9bLtBPi8VPYqRLmP+xRT6TaynchVkqVHc +zFjKDvG4BFm+y0hOAmutAKije5e8uslKiP64BJvnaYvHFe+iI9rMxVNzIUvWiY0JpWx EvUJ+7BYCtxK9Aw/+xyZOgqc/u98NqF3QnVE37EQPbWtUY+2ilLhnpQHnDN4zHfAvA4K ke0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oVYoHb0j5VFpSmctH5aR8XGJ4ktZiFaaq0zVF+LId6M=; b=V1uob+C9S2XrJBDprSGS1SvXla6jKaaRra7kt8WQPiCuEQsB0szKRI5SYQ1Sk0UabJ 4ZquAOK0t5q1EAC8G+PWxDdcFDQTQhww65gAGzwAU5lY2oUCb6RZNiqNsE4SclLeXxyH sgxdaQk4UaRw5etQ6ditLnF9i9qPG5gJMvmAKkUDhrFhQL1UK+zq79FYISKd/c5EShjo tMkCKNKyTq2wFwBU0+c13BgiHyuXbdsZ4IchEjeEU1lyGGPGIiUVN4M1UuOiH2poH0iv 1b4cV687af7SE3pvQ3/VkBe5YOqAA6H+gGBYFhPqCAW3NeAUOk3NcHlEonCr9mD02umy AqzQ== X-Gm-Message-State: AOAM531rT7CHFLZbSHntFCKVdc6sXKXi3jG2+y0JIas/zG7ugBZMpdMe TyA03/KfkLAxDZ+XXQpiFt0= X-Google-Smtp-Source: ABdhPJyoXlMRwGItruwsciGuyz3DA7HhF4EfUhAvxkd5DHvXOkbFQAE5LlaG+9S92qRtX/BA+PDpFQ== X-Received: by 2002:a05:6512:3c8c:: with SMTP id h12mr19976447lfv.388.1619599254899; Wed, 28 Apr 2021 01:40:54 -0700 (PDT) Received: from [192.168.1.100] ([31.173.87.27]) by smtp.gmail.com with ESMTPSA id a20sm1005787ljd.105.2021.04.28.01.40.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 01:40:54 -0700 (PDT) Subject: Re: [PATCH] ata: ahci_sunxi: Disable DIPM To: Timo Sigurdsson , axboe@kernel.dk, mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: oliver@schinagl.nl, stable@vger.kernel.org References: <20210427230537.21423-1-public_timo.s@silentcreek.de> From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: <24eb672c-9772-4e3f-e3de-0fe3390c659f@gmail.com> Date: Wed, 28 Apr 2021 11:40:44 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210427230537.21423-1-public_timo.s@silentcreek.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_014057_528347_D91706FD X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On 28.04.2021 2:05, Timo Sigurdsson wrote: > DIPM is unsupported or broken on sunxi. Trying to enable the power > management policy med_power_with_dipm on an Allwinner A20 SoC based board > leads to immediate I/O errors and the attached SATA disk disappears from > the /dev filesystem. A reset (power cycle) is required to make the SATA > controller or disk work again. The A10 and A20 SoC data sheets and manuals > don't mention DIPM at all [1], so it's fair to assume that it's simply not > supported. But even if it were, it should be considered broken and best be ^ was > disabled in the ahci_sunxi driver. > > Fixes: c5754b5220f0 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform") The "Fixes:" tag should immediately precede the signoff tag... > [1] https://github.com/allwinner-zh/documents/tree/master/ And this line should be immediately after the patch description. > Signed-off-by: Timo Sigurdsson > Tested-by: Timo Sigurdsson [...] MBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel