From: Florian Fainelli <f.fainelli@gmail.com>
To: Dhruva Gole <d-gole@ti.com>, Mark Brown <broonie@kernel.org>
Cc: Vaishnav Achath <vaishnav.a@ti.com>, Vignesh <vigneshr@ti.com>,
Apurva Nandan <a-nandan@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Tanguy Bouzeloc <tanguy.bouzeloc@efixo.com>
Subject: Re: [PATCH] spi: bcm63xx: remove PM_SLEEP based conditional compilation
Date: Fri, 21 Apr 2023 10:13:12 -0700 [thread overview]
Message-ID: <24ec3728-9720-ae6a-9ff5-3e2e13a96f76@gmail.com> (raw)
In-Reply-To: <20230420121615.967487-1-d-gole@ti.com>
On 4/20/23 05:16, Dhruva Gole wrote:
> Get rid of conditional compilation based on CONFIG_PM_SLEEP because
> it may introduce build issues with certain configs where it maybe disabled
> This is because if above config is not enabled the suspend-resume
> functions are never part of the code but the bcm63xx_spi_pm_ops struct
> still inits them to non-existent suspend-resume functions.
>
> Fixes: b42dfed83d95 ("spi: add Broadcom BCM63xx SPI controller driver")
>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
> drivers/spi/spi-bcm63xx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 96633a0051b1..99395932074c 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -617,7 +617,6 @@ static void bcm63xx_spi_remove(struct platform_device *pdev)
> clk_disable_unprepare(bs->clk);
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int bcm63xx_spi_suspend(struct device *dev)
Don't we need a __maybe_unused here?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-21 17:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:16 [PATCH] spi: bcm63xx: remove PM_SLEEP based conditional compilation Dhruva Gole
2023-04-21 16:06 ` Mark Brown
2023-04-21 17:13 ` Florian Fainelli [this message]
2023-04-24 8:20 ` Jonas Gorski
2023-04-24 10:26 ` Dhruva Gole
2023-04-25 15:08 ` Guenter Roeck
2023-04-25 17:18 ` Gole, Dhruva
2023-04-25 17:37 ` Guenter Roeck
2023-04-25 18:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24ec3728-9720-ae6a-9ff5-3e2e13a96f76@gmail.com \
--to=f.fainelli@gmail.com \
--cc=a-nandan@ti.com \
--cc=broonie@kernel.org \
--cc=d-gole@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=tanguy.bouzeloc@efixo.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox