From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10B1BC7618E for ; Fri, 21 Apr 2023 17:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q1hBsnccSsmuWoSvFlM3muXvplxi4Yw7+cN5osLFg3k=; b=0RtcHRdzbDS2aP LaIP5FFVF+bQIuFZAWkevou6cFwzqKIA04wvVkv9pPt8Xw5GoBlerGsJ/J3vW3b8FD4EJuvg/oGwo cLJjeeIcfHhjAevT3Jkw4GbOfdd5tpl3InYK+b6SgUnasUSr+S45gY4QLMNLhfM6jHm2mIzQWr0Nt G2Y1UpNQ4ovQLJM07mHs+RUR3L8U/ev2J0G/UDepfjqMoPLmIwwqQhNXt+3ivL+BoX0b5vx08ioS9 Tb944BgErhVWitGtxkBLuJwadEbHBbWBKRShsELQEfNcYclVSblg0bVJ6nLFMnpmeKW/75JFMm2JC zJeYkG4xYYAv3E2sVSRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppuK5-00BTHT-1g; Fri, 21 Apr 2023 17:13:25 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppuK3-00BTGt-1T for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2023 17:13:24 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-63d2ba63dddso2076065b3a.2 for ; Fri, 21 Apr 2023 10:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682097201; x=1684689201; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wtv/plYjg6t5+KIhqn4HLpoeS3qH6YTzNA/OWZvr4S0=; b=FjEVhsbuInMEEPWXdLhRhcGP7c0Mf3zoia/8MpkI3FFi8bXXeWe4n6ptt+1a4zdrg5 FNqYWJH1xCmVEZhstLN2AY9j/okpz1gYfJeSgdtNavogVsNgAQ5R8ZrEmOeH9LRu9LZ8 FkvW9GQk6BZqdH44lftdYbIwBPC3Z4QCmMjJg12Yt7CJ2UvD21aHSDyI6cqr0NPtz2Od xglJwazptN44LPeHcJJjTDu2mrW5MEeUfV5ul8U1vlx9SIjIlN0N5LeTPodvIpPNG7HS NY6kGx+cCheUAowDO9nGtRHddThNXORJLc8DkvNUmRM7XeJCoOhtQsFLA2muTX8IIU0T IFRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682097201; x=1684689201; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wtv/plYjg6t5+KIhqn4HLpoeS3qH6YTzNA/OWZvr4S0=; b=bbpQt5+R/XZCy7ZPm2Rn3USrus/Qhcp6I94jUkSz8qaftZgiuid248JpUEhlXgoLUE hJ8p86DnzJRZHNKtJVrFUE5BYu4XWzXdTFcrGluk7AR/rWIPrjaq5TG/ZdlygO4+4IDm DU/Y3l/2ijMRapJnqHOZjvnTUm8K/L0aDeaxtkNRb+cYaDC9qaQEXfKHmOu1qFzH7+3Z xOvS+w6tPvFGuoDzjlcDxKHUVMAEYCEhfb8qoBy7Kr2Qbm62cLnrJ9QDPmFYXlPFezhK Rrs3o8SGopLaNJ242GJi0ouxOlVschx3j97QthxVmC2LQ5IZO922rg9TyMQRbtJjy9kI t4/Q== X-Gm-Message-State: AAQBX9c06dfUCqbod5ohQDo46noSDP9lQ5XQyuuk55umatOQxKf/mnpj rLJgbRZakti+/2ympCsULOmPxSZ6w4byLg== X-Google-Smtp-Source: AKy350aW0P/FC8UFKP2uDVDZSV2ognzE+Ons42k3+QvxKksi2a70BP+43x0RqhleMO7/CgeLtZL1Fw== X-Received: by 2002:a17:90a:9708:b0:22c:59c3:8694 with SMTP id x8-20020a17090a970800b0022c59c38694mr5906384pjo.44.1682097201450; Fri, 21 Apr 2023 10:13:21 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id y18-20020a17090aa41200b00244991b3f7asm5549150pjp.1.2023.04.21.10.13.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 10:13:20 -0700 (PDT) Message-ID: <24ec3728-9720-ae6a-9ff5-3e2e13a96f76@gmail.com> Date: Fri, 21 Apr 2023 10:13:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] spi: bcm63xx: remove PM_SLEEP based conditional compilation Content-Language: en-US To: Dhruva Gole , Mark Brown Cc: Vaishnav Achath , Vignesh , Apurva Nandan , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Grant Likely , Tanguy Bouzeloc References: <20230420121615.967487-1-d-gole@ti.com> From: Florian Fainelli In-Reply-To: <20230420121615.967487-1-d-gole@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_101323_500064_98E8E4E6 X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/20/23 05:16, Dhruva Gole wrote: > Get rid of conditional compilation based on CONFIG_PM_SLEEP because > it may introduce build issues with certain configs where it maybe disabled > This is because if above config is not enabled the suspend-resume > functions are never part of the code but the bcm63xx_spi_pm_ops struct > still inits them to non-existent suspend-resume functions. > > Fixes: b42dfed83d95 ("spi: add Broadcom BCM63xx SPI controller driver") > > Signed-off-by: Dhruva Gole > --- > drivers/spi/spi-bcm63xx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c > index 96633a0051b1..99395932074c 100644 > --- a/drivers/spi/spi-bcm63xx.c > +++ b/drivers/spi/spi-bcm63xx.c > @@ -617,7 +617,6 @@ static void bcm63xx_spi_remove(struct platform_device *pdev) > clk_disable_unprepare(bs->clk); > } > > -#ifdef CONFIG_PM_SLEEP > static int bcm63xx_spi_suspend(struct device *dev) Don't we need a __maybe_unused here? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel