From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80499C433B4 for ; Wed, 21 Apr 2021 07:51:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2AA86142C for ; Wed, 21 Apr 2021 07:51:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2AA86142C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cjdd0eH1x8yR9gzdRWO4qTqtSb4ljUwkwEBFx6Mcvqw=; b=CCumyMQOWjP3wVsLKD+XBikeu nHOXItuhfALS1jbRVuUaENy4rXIMo6E+FlVTZL6kGpiD8cW2LuLLeX33Sx5CAeP9yc7KFivbNpXKH bOgn4rGcDMNWSE2VcNIaJr6hyXrbAACDoi54cyucAM1iea2utZUFbWw3O1girf7toL2Yt7YovVtVM OBfqI3MDheyzTkCYIzPqVYslt8QbuD0FM4M9MrGOfLGxjwM3csmMS3eO6+owjj4n4ZyfSxlSjW0YR bm9OCfW4lVjjXajmM85cndOAZQdUVrIlai799cmkKX7j6r2zzMXI7c4xYROTrW5WxQF9FUhhn7Uoe D+UK3eljg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZ7bq-00DvHO-Or; Wed, 21 Apr 2021 07:49:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZ7bk-00DvH2-Eb for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 07:49:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=yo0aeP/gZ7xIL1Br7EZck8Ru/9tRz4VORS9chdtNmnw=; b=KgDvXCtbinkOn0dXQ4MUfKGUv/ yDNzuv2CbJW6u0+qw2P0loWdyihAajnG7gA0nbcQ9+L/gjxT03SZo+bSqjVjEUk4fpj4Yc29nrqlQ hK+WQaRKKw54a9GNw86UH98yOmckiWxWXf5LN9JnEjsvnLbZZvBZtqysOiTnU32BHky5jXd+yqfua 8uvDpcCcNYIkpf12UdSI0HtUARluXFoFkAkNRbwd7daCZGmRXntwRGGhSrk23ag5IEgdScgjC0KYi HTaCGpZSdMvh9ioOaeLWhTRjyEbtMF7sZosYJn6FqjNj0g1fGzPTIkAiw5lcECYLFh9vAv1AWwb0M T6/08qUg==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZ7bh-00CgU6-Oc for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 07:49:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618991348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yo0aeP/gZ7xIL1Br7EZck8Ru/9tRz4VORS9chdtNmnw=; b=D/wqECXs8LKlnb+aeRo1Fcdtr8fW2oTZRei0JOUvd7G17gdAf2GkY+8+4Mjl3GLTY+26MA L9rJSsPeuzKOv/4MGHOegaKTRGNdlHJ/9Qhi5ouIihTmxzwr/ahD6gk0MmGTY9jDk6WtfB Hoo4iK5pDeTnj7B760KNTM1931lyRY0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-n856Z86eN869E2vPZCagDw-1; Wed, 21 Apr 2021 03:49:04 -0400 X-MC-Unique: n856Z86eN869E2vPZCagDw-1 Received: by mail-ed1-f72.google.com with SMTP id l22-20020a0564021256b0290384ebfba68cso10711166edw.2 for ; Wed, 21 Apr 2021 00:49:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yo0aeP/gZ7xIL1Br7EZck8Ru/9tRz4VORS9chdtNmnw=; b=npLvx8aFTZiWFZXg6PTZE7IL4yugazVSmdprrhdyS2PPlNqtnxRu60zC91raCW1EEs R9O+ygevDRCSgG+WBuX39MJJLcnVe1AknkHBtaOwKEdOxwQyDFNqPdyJhdNdRsQgW5hJ ZN2T5kAz9LbKCVK/E+obXdFZbmcsKMjEEbMRKs022jUH1Fp2fIO7BJA/cMPfEbD5v7/a fOZCBCaMF6OQ2IWOvF2OCnzH0/jTXw/kAxJHKDstdufN0G5evXa1j+C8wPysivyD71M0 Q9FlXOU6c8luwmBhG+u34/QVlRt4CV0xCHjCOjqR07X6BExW+QHmOn70TVdzMOGs5ETn ungg== X-Gm-Message-State: AOAM533Vd2qFz4uKQ08izwEw7YDiBNNgptlvvwLi09LURLc7/V48WMa4 HVBOLZBLWNX38uJEHKVEGdz4yEx8cx4no039sC+7GAmo6SFkKG3oZKqzFPe84akOBy3UZjmzsBS lppMsrxFORRbkKQzty8ZKa3Lds7CR8DqT5SQ= X-Received: by 2002:a17:906:a0c2:: with SMTP id bh2mr30655393ejb.394.1618991343593; Wed, 21 Apr 2021 00:49:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCI5v3IslAnTd1D5vuwywZ+19uA0jnaa9i2DYeKnzLSV7LTGXv7KAxF6ZWHxxr+Z98bKaYGg== X-Received: by 2002:a17:906:a0c2:: with SMTP id bh2mr30655371ejb.394.1618991343356; Wed, 21 Apr 2021 00:49:03 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64b8.dip0.t-ipconnect.de. [91.12.100.184]) by smtp.gmail.com with ESMTPSA id ju23sm1495102ejc.17.2021.04.21.00.49.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 00:49:03 -0700 (PDT) Subject: Re: [PATCH v2 4/4] arm64: drop pfn_valid_within() and simplify pfn_valid() To: Mike Rapoport , linux-arm-kernel@lists.infradead.org Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210421065108.1987-1-rppt@kernel.org> <20210421065108.1987-5-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <24edab0c-226c-7ff6-2151-7a8b218c7c44@redhat.com> Date: Wed, 21 Apr 2021 09:49:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210421065108.1987-5-rppt@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_004909_895380_C0328CED X-CRM114-Status: GOOD ( 31.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.04.21 08:51, Mike Rapoport wrote: > From: Mike Rapoport > > The arm64's version of pfn_valid() differs from the generic because of two > reasons: > > * Parts of the memory map are freed during boot. This makes it necessary to > verify that there is actual physical memory that corresponds to a pfn > which is done by querying memblock. > > * There are NOMAP memory regions. These regions are not mapped in the > linear map and until the previous commit the struct pages representing > these areas had default values. > > As the consequence of absence of the special treatment of NOMAP regions in > the memory map it was necessary to use memblock_is_map_memory() in > pfn_valid() and to have pfn_valid_within() aliased to pfn_valid() so that > generic mm functionality would not treat a NOMAP page as a normal page. > > Since the NOMAP regions are now marked as PageReserved(), pfn walkers and > the rest of core mm will treat them as unusable memory and thus > pfn_valid_within() is no longer required at all and can be disabled by > removing CONFIG_HOLES_IN_ZONE on arm64. > > pfn_valid() can be slightly simplified by replacing > memblock_is_map_memory() with memblock_is_memory(). > > Signed-off-by: Mike Rapoport > --- > arch/arm64/Kconfig | 3 --- > arch/arm64/mm/init.c | 4 ++-- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index e4e1b6550115..58e439046d05 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1040,9 +1040,6 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK > def_bool y > depends on NUMA > > -config HOLES_IN_ZONE > - def_bool y > - > source "kernel/Kconfig.hz" > > config ARCH_SPARSEMEM_ENABLE > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index dc03bdc12c0f..eb3f56fb8c7c 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -243,7 +243,7 @@ int pfn_valid(unsigned long pfn) > > /* > * ZONE_DEVICE memory does not have the memblock entries. > - * memblock_is_map_memory() check for ZONE_DEVICE based > + * memblock_is_memory() check for ZONE_DEVICE based > * addresses will always fail. Even the normal hotplugged > * memory will never have MEMBLOCK_NOMAP flag set in their > * memblock entries. Skip memblock search for all non early > @@ -254,7 +254,7 @@ int pfn_valid(unsigned long pfn) > return pfn_section_valid(ms, pfn); > } > #endif > - return memblock_is_map_memory(addr); > + return memblock_is_memory(addr); > } > EXPORT_SYMBOL(pfn_valid); > > Acked-by: David Hildenbrand -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel