From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 546C4CDB47E for ; Wed, 18 Oct 2023 05:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2FqlxEi/n1LMizYURubzjBlzm1GqnIZRgKBLxpJzu6A=; b=ZKHaGGiX7xHWqk Al7YzeH+KaktMza3zYnkbJdNdQwl1+ZJfybk9CZiPWrA5yvMCyIx7hqrFsTo7ikflZOT5HxbAvD02 beilFqtyNpedSPzW9w+Ep8jxneQdATOzhx72txiTM05v0Lgkk2q20SBb6SHjkCZKGN3yUnCYPb9E5 BGg9VNEiPPWgDl5MqiD4kCerFuKVhU7rckfz8Rr2gbPOk++Gl0XvvAUb4DEEBBmgeGsrsx182xtIE KXqXN/Jl2yveBCd+iHYRJ6RMIFYCDZsjyKxOeI0CvsRcL19DCqIBBNDjqI6jqNwDZlxQk8TEtzzkR MLHQFWEn6RSc/E8Pcf6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qszX6-00DrNy-17; Wed, 18 Oct 2023 05:55:52 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qszX2-00DrMd-1w for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 05:55:50 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qszWg-0007hK-2U; Wed, 18 Oct 2023 07:55:26 +0200 Message-ID: <24f14f0f-2a1b-401d-b5f8-314387d0aaef@pengutronix.de> Date: Wed, 18 Oct 2023 07:55:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index Content-Language: en-US, de-DE To: Jakub Kicinski , Marc Kleine-Budde Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, Maxime Coquelin , netdev@vger.kernel.org, Richard Cochran , Kurt Kanzenbach , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, Eric Dumazet , Jose Abreu , Simon Horman , Paolo Abeni , "David S. Miller" , linux-arm-kernel@lists.infradead.org, patchwork-jzi@pengutronix.de References: <20231010-stmmac_fix_auxiliary_event_capture-v1-0-3eeca9e844fa@pengutronix.de> <20231010-stmmac_fix_auxiliary_event_capture-v1-2-3eeca9e844fa@pengutronix.de> <20231014144428.GA1386676@kernel.org> <004d6ce9-7d15-4944-b31c-c9e628e7483a@pengutronix.de> <20231017082618.4558ad06@kernel.org> <20231017-transfer-refurbish-5cfaf12a524c-mkl@pengutronix.de> <20231017165042.30fa9061@kernel.org> From: Johannes Zink In-Reply-To: <20231017165042.30fa9061@kernel.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: j.zink@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_225548_638658_9D06E121 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jakub, hi Marc, On 10/18/23 01:50, Jakub Kicinski wrote: > On Tue, 17 Oct 2023 22:27:41 +0200 Marc Kleine-Budde wrote: >>> Would be good to clarify what impact on device operation the problem >>> has. How would end user notice the problem? >>> Does it mean snapshots were always or never enabled, previously? >> >> On all dwmac devices not covered by dwmac-intel.c (INTEL 10/100/1000 >> Ethernet PCI driver), PPS capture can be requested from user-space, but >> is not enabled in HW. There is no error message or other feedback to the >> user space. The user space will not get any PPS events. >> >> As this change also affects the Intel driver, and we don't have any >> hardware to test, I think it's better that this goes via net-next to >> give it a bit more time of testing. I have also CC'ed Kurt in this series, as I know he has at least some hardware at hand, though I cannot tell whether he has any chance to test the PPS capture. Maybe he has a possibility to try it out. However, giving it a spin in net-next SGTM. > > SGTM, we can chalk it up to "never worked, doesn't hurt anyone" > and put it in net-next. But then the Fixes tag must go. > sure, that's fine for me. I will reword the commit messages and send a v2. Best regards, Johannes -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel