From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andy Yan <andyshrk@163.com>, heiko@sntech.de
Cc: dsimic@manjaro.org, krzk+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook
Date: Sun, 28 Jul 2024 11:15:14 +0200 [thread overview]
Message-ID: <24f35b29-20ee-4bdc-aac5-5de5d5e0fb83@kernel.org> (raw)
In-Reply-To: <20240728082004.36575-2-andyshrk@163.com>
On 28/07/2024 10:20, Andy Yan wrote:
> Add Cool Pi CM5 GenBook, a laptop powered by RK3588.
>
> Cool Pi GenBook works with a carrier board connect
> with CM5.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Andy Yan <andyshrk@163.com>
>
> ---
>
> Changes in v2:
> - Descripte it as Cool Pi CM5 GenBook
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf..a9bfb87e69f5 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -96,6 +96,14 @@ properties:
> - const: coolpi,pi-cm5
> - const: rockchip,rk3588
>
> + - description: Cool Pi CM5 GenBook
> + items:
> + - enum:
> + - coolpi,genbook
> + - const: coolpi,pi-cm5
> + - const: rockchip,rk3588
> +
> +
Just one blank line. Please always take a look how the code looks around
and do not implement things entirely different. Like odd blank lines.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-28 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 8:20 [PATCH v2 0/2] Add support for Cool Pi GenBook Andy Yan
2024-07-28 8:20 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook Andy Yan
2024-07-28 9:15 ` Krzysztof Kozlowski [this message]
2024-07-28 9:22 ` Dragan Simic
2024-07-28 8:20 ` [PATCH v2 2/2] arm64: dts: rockchip: Add support for rk3588 based " Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f35b29-20ee-4bdc-aac5-5de5d5e0fb83@kernel.org \
--to=krzk@kernel.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox