From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FC4AC52D71 for ; Fri, 9 Aug 2024 05:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=la+Tef+tf7IOZApYVOkZvDzT+lX0Qi2P3P3S1j0smEE=; b=YFvQ8z8W7shjvRPpT0SUbMRH7D NjizmumhYFGOODPR7PFeVSbMogGrv70oC2kxCY3iks5Gpi616rFmIAimdm1Cyk43OybEhZkxicsTb exCPAlmTyBHhGuNCxMY43kRcRXDEOLiTPUi+ajBT9mWC22g87fjiFxLKrG4R/ZZNcYu7EpCFbvaxj DdTyQXocTW64iimyGWP2Nd99e+9nn2/kw93esywyUyzfAwhhD3bBlgTICwzCDLkcUWzAVNU543lyg EODj/SWR80rb7tmsyXPq8aA9XOvUC2a9aIo66LzxxO35MYGCAiemMvgdXSxJJAvunIlQ91ZMRLI7U oCOy5QTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scIUa-0000000AKqa-10Cv; Fri, 09 Aug 2024 05:48:48 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scIU0-0000000AKk6-2nCS for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 05:48:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9A883CE16C8; Fri, 9 Aug 2024 05:48:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53B22C4AF0D; Fri, 9 Aug 2024 05:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723182489; bh=ZBQK+cbyO3xbcABhYXubKQT9HZMHXAWWe28Kv1YxKDE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IyTdpGZfgucxMsMteD4O3tm5OW9PJ32VebeC4RBMNPQ8uRbup0s1+Dhfz0w32G6Eb EZg+uADXGFqBR5ITIVqwI8aLv0e0zq/Edk3sCQPp1N4MfZ4ODTVM4sqJBwgEhLMWQI 72CK2Nu2tERBQivQpsgpf9GWjK4cl002xc/2rQ/HzotNnmwIU+bMSsVRrCEMsB05xp BLoFiPXtMxUs03LZ6FY/gJQp4UrfIAV7ZKBFnfMjxkTPoKBleUl7fakDiEWTYq0xdb afmolI9HUpDcd/mzhz4MnLo7J8xYLryd8cm9Hhw3u5SvEJo40et8bB8XBNAd3RwiS+ Yu80QZuEY0XyQ== Message-ID: <24ff07b6-a685-471f-8249-3e3450e2d3d3@kernel.org> Date: Fri, 9 Aug 2024 07:48:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 08/10] arm64: dts: exynos: Add initial support for exynos8895 SoC To: Ivaylo Ivanov , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Sylwester Nawrocki , Linus Walleij , Rob Herring Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240807082843.352937-1-ivo.ivanov.ivanov1@gmail.com> <20240807082843.352937-9-ivo.ivanov.ivanov1@gmail.com> <5274b8a1-b81c-3979-ed6c-3572f6a6cfc2@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <5274b8a1-b81c-3979-ed6c-3572f6a6cfc2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_224813_127583_4F9B3B8D X-CRM114-Status: GOOD ( 21.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/08/2024 13:20, Ivaylo Ivanov wrote: > > On 8/7/24 12:20, Krzysztof Kozlowski wrote: >> On 07/08/2024 10:28, ivo.ivanov.ivanov1@gmail.com wrote: >>> From: Ivaylo Ivanov >>> >>> Exynos 8895 SoC is an ARMv8 mobile SoC found in the Samsung Galaxy >>> S8 (dreamlte), S8 Plus (dream2lte), Note 8 (greatlte) and the Meizu >>> 15 Plus (m1891). Add minimal support for that SoC, including: >>> >>> - All 8 cores via PSCI >>> - ChipID >>> - Generic ARMV8 Timer >>> - Enumarate all pinctrl nodes >>> >>> Further platform support will be added over time. >>> >>> Signed-off-by: Ivaylo Ivanov >>> --- >>> .../boot/dts/exynos/exynos8895-pinctrl.dtsi | 1378 +++++++++++++++++ >>> arch/arm64/boot/dts/exynos/exynos8895.dtsi | 253 +++ >>> 2 files changed, 1631 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi >>> create mode 100644 arch/arm64/boot/dts/exynos/exynos8895.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi >>> new file mode 100644 >>> index 000000000..1dcb61e2e >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/exynos/exynos8895-pinctrl.dtsi >>> @@ -0,0 +1,1378 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Samsung's Exynos 8895 SoC pin-mux and pin-config device tree source >>> + * >>> + * Copyright (c) 2024, Ivaylo Ivanov >>> + */ >>> + >>> +#include >>> +#include "exynos-pinctrl.h" >>> + >>> +&pinctrl_alive { >>> + gpa0: gpa0 { >> I do not believe this was tested. See maintainer SoC profile for Samsung >> Exynos. >> >> Limited review follows due to lack of testing. >> >> >>> +}; >>> diff --git a/arch/arm64/boot/dts/exynos/exynos8895.dtsi b/arch/arm64/boot/dts/exynos/exynos8895.dtsi >>> new file mode 100644 >>> index 000000000..3ed381ee5 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/exynos/exynos8895.dtsi >>> @@ -0,0 +1,253 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Samsung's Exynos 8895 SoC device tree source >>> + * >>> + * Copyright (c) 2024, Ivaylo Ivanov >>> + */ >>> + >>> +#include >>> + >>> +/ { >>> + compatible = "samsung,exynos8895"; >>> + #address-cells = <2>; >>> + #size-cells = <1>; >>> + >>> + interrupt-parent = <&gic>; >>> + >>> + aliases { >>> + pinctrl0 = &pinctrl_alive; >>> + pinctrl1 = &pinctrl_abox; >>> + pinctrl2 = &pinctrl_vts; >>> + pinctrl3 = &pinctrl_fsys0; >>> + pinctrl4 = &pinctrl_fsys1; >>> + pinctrl5 = &pinctrl_busc; >>> + pinctrl6 = &pinctrl_peric0; >>> + pinctrl7 = &pinctrl_peric1; >>> + }; >>> + >>> + arm-a53-pmu { >> Are there two pmus? > > Hm. The Downstream kernel has them all under one node with compatible > > 'arm,armv8-pmuv3', same as with Exynos 7885. So it should have two PMUs, > > one for each cluster. > > > Considering the second cluster consists of Samsung's custom Mongoose M2 > > cores, what would be the most adequate thing to do? Keep the first PMU as > > "arm,cortex-a53-pmu" and use the SW model "arm,armv8-pmuv3" for the > > second PMU? I doubt guessing if these mongoose cores are based on already > > existing cortex cores is a great idea. I was just wondering why there is only one and called a53. I am not sure what should be for the second, but rather not a software model. Best regards, Krzysztof