From: "Heiko Stübner" <heiko@sntech.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Sandy Huang <hjc@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes
Date: Thu, 05 May 2022 09:23:03 +0200 [thread overview]
Message-ID: <2508329.Lt9SDvczpP@diego> (raw)
In-Reply-To: <20220505064131.GF4012@pengutronix.de>
Am Donnerstag, 5. Mai 2022, 08:41:31 CEST schrieb Sascha Hauer:
> On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko Stübner wrote:
> > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer:
> > > The VOP2 is the display output controller on the RK3568. Add the node
> > > for it to the dtsi file along with the required display-subsystem node
> > > and the iommu node.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > Acked-by: Rob Herring <robh@kernel.org>
> > > ---
> > > + vop: vop@fe040000 {
> > > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>;
> > > + reg-names = "regs", "gamma_lut";
> >
> > reg-names does not seem to be part of the dt-binding.
> > Though now in the vop2-driver I see that the code uses that naming.
> >
> > I guess we might want to just go the vop1-way by using numbered
> > platform-resources via a follow-up patch and drop the regnames here?
>
> Or we could document the reg-names properties in a follow-up patch.
> Wouldn't that be better?
Also a possibility. Although that of course leads us into the naming
bike-shed ;-) ... i.e. for reg-names I'd do "vop" + "gamme-lut" (dash instead
of underscore) - instead of the ones used right now.
While using numbered resources would keep the commonality between
both vops
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-05 7:24 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:28 [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 01/24] clk: rk3568: Mark hclk_vo as critical Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 02/24] drm/rockchip: Embed drm_encoder into rockchip_decoder Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 03/24] drm/rockchip: Add crtc_endpoint_id to rockchip_encoder Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 04/24] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 05/24] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 06/24] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 07/24] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 08/24] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 09/24] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2024-07-04 9:09 ` Diederik de Haas
2024-07-04 10:00 ` Heiko Stübner
2024-07-04 10:34 ` Diederik de Haas
2024-07-04 10:28 ` Alex Bee
2022-04-22 7:28 ` [PATCH v11 10/24] dt-bindings: display: rockchip: dw-hdmi: Add " Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 11/24] drm/rockchip: dw_hdmi: Use auto-generated tables Sascha Hauer
2022-05-03 11:02 ` Heiko Stübner
2022-05-03 12:17 ` Robin Murphy
2022-04-22 7:28 ` [PATCH v11 12/24] drm/rockchip: dw_hdmi: relax mode_valid hook Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 13/24] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 14/24] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 15/24] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2022-05-05 0:28 ` Heiko Stübner
2022-05-05 6:41 ` Sascha Hauer
2022-05-05 7:23 ` Heiko Stübner [this message]
2022-05-06 7:10 ` Sascha Hauer
2022-05-06 8:54 ` Heiko Stuebner
2022-04-22 7:28 ` [PATCH v11 17/24] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2022-05-05 8:45 ` Aw: " Frank Wunderlich
2022-05-05 9:05 ` Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 18/24] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 19/24] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a Sascha Hauer
2022-05-08 13:40 ` Piotr Oniszczuk
2022-05-08 16:53 ` Peter Geis
2022-05-08 17:36 ` Piotr Oniszczuk
2022-05-08 18:00 ` Peter Geis
2022-05-08 18:21 ` Piotr Oniszczuk
2022-05-09 16:00 ` Peter Geis
2022-05-09 19:49 ` Piotr Oniszczuk
2022-05-10 1:35 ` Peter Geis
2022-05-10 7:29 ` Piotr Oniszczuk
2022-05-10 12:08 ` Peter Geis
2022-05-10 13:49 ` Piotr Oniszczuk
2022-05-10 20:54 ` Peter Geis
2022-05-10 22:49 ` Peter Geis
2022-05-11 16:17 ` Piotr Oniszczuk
2022-05-14 13:58 ` Piotr Oniszczuk
2022-06-24 8:29 ` Piotr Oniszczuk
2022-06-24 12:40 ` Peter Geis
2022-06-24 18:57 ` Piotr Oniszczuk
2022-06-24 23:50 ` Peter Geis
2022-06-25 13:18 ` Piotr Oniszczuk
2022-06-25 14:00 ` Peter Geis
2022-06-25 15:31 ` Piotr Oniszczuk
2022-07-10 17:01 ` Piotr Oniszczuk
2022-07-11 10:41 ` Robin Murphy
2022-07-11 11:04 ` Piotr Oniszczuk
2022-07-11 11:34 ` Robin Murphy
2022-05-12 12:17 ` Robin Murphy
2022-05-12 13:01 ` Peter Geis
2022-04-22 7:28 ` [PATCH v11 21/24] drm/rockchip: Make VOP driver optional Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 23/24] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2022-04-22 7:28 ` [PATCH v11 24/24] dt-bindings: display: rockchip: dw-hdmi: fix ports description Sascha Hauer
2022-04-25 12:34 ` [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support Michael Riesch
2022-04-25 14:48 ` Daniel Stone
2022-05-03 9:12 ` (subset) " Heiko Stuebner
2022-05-03 9:26 ` Heiko Stuebner
2022-05-03 9:29 ` Heiko Stuebner
2022-05-03 11:02 ` Heiko Stuebner
2022-05-04 12:08 ` Heiko Stuebner
2022-05-17 18:22 ` Heiko Stuebner
2022-05-17 18:27 ` Heiko Stuebner
2022-05-20 10:02 ` Maya Matuszczyk
2022-05-20 10:12 ` Sascha Hauer
2022-05-20 11:56 ` Peter Geis
2022-05-20 12:15 ` Maya Matuszczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2508329.Lt9SDvczpP@diego \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).