From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0870BC433E0 for ; Thu, 11 Mar 2021 22:01:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7880064F6B for ; Thu, 11 Mar 2021 22:01:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7880064F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y2qdSU/0icw/1obDWDfdNQ00MLlc1gdXpQ1vsVhx7qY=; b=Hal/vQC4BrFUGv2rJopXqdsZX fIuZFotE3dlkfQ92zp4GKzfoRVVC/k7ISVWDS0sVJex5QmnMpo4TzARoaFltvGxvc1el0r9BxALn0 +jd8sZqesKbR/nNtmiVhQr0YuvBgPRDiBYEi0ASSsb8/Q+SnVrDCSQAz/L0Go7iFv5BXdN1XkZk30 nDc7Yj6bVlfK/xlQKL4tx7yxE2AM/1JV9wTv5NzzI5xuJwPSHdve901BD/co2uaogttggslNtMZVB G54x1KzKYchWkngI0Vk/GP0ehiQNjI4E1jWHNAPJ/qG2DNldNYRl5RiniDvt7214y7jE4GlyGQhRm 9UBI6xMbg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKTLN-00A8TW-OA; Thu, 11 Mar 2021 21:59:45 +0000 Received: from mailoutvs12.siol.net ([185.57.226.203] helo=mail.siol.net) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKTLG-00A8Ss-SF for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 21:59:41 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 7D6D0524AD8; Thu, 11 Mar 2021 22:59:36 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id doooZCoLUepj; Thu, 11 Mar 2021 22:59:36 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 34F9D524D14; Thu, 11 Mar 2021 22:59:36 +0100 (CET) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net [86.58.17.133]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 7C948524AD8; Thu, 11 Mar 2021 22:59:35 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Cc: wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: Re: [PATCH] ARM: dts: sun8i: h3: beelink-x2: Add power button Date: Thu, 11 Mar 2021 22:59:35 +0100 Message-ID: <2517400.0zBCEEo8qi@kista> In-Reply-To: <20210308130506.v35gjviwknr5hat5@gilmour> References: <20210306203611.15534-1-jernej.skrabec@siol.net> <20210308130506.v35gjviwknr5hat5@gilmour> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_215939_102822_D882FD59 X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Dne ponedeljek, 08. marec 2021 ob 14:05:06 CET je Maxime Ripard napisal(a): > Hi > > On Sat, Mar 06, 2021 at 09:36:11PM +0100, Jernej Skrabec wrote: > > Beelink X2 has power button. Add node for it. > > > > Signed-off-by: Jernej Skrabec > > --- > > arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/ sun8i-h3-beelink-x2.dts > > index 62b5280ec093..4a2cb072ecf6 100644 > > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > > @@ -111,6 +111,17 @@ spdif_out: spdif-out { > > #sound-dai-cells = <0>; > > compatible = "linux,spdif-dit"; > > }; > > + > > + r_gpio_keys { > > Underscores are not valid for node names (and will trigger a dtc warning > when running with W=1). Unless I'm doing something wrong, I didn't get any warning with "make dtbs W=1". In fact many H3 boards have a node with this name and not a single warning is produced with this command for underscores (there are other warnings though). Actually, several H3 DT files have nodes like "sound_spdif" or "wifi_pwrseq". It seems like warnings are triggered only for children of soc node. > > > + compatible = "gpio-keys"; > > + > > + power { > > + label = "power"; > > IIRC the node name is used as a fallback when the label isn't there? Binding doesn't say anything about what happens if label is missing. Driver sets generic description "gpio_keys" in such case, which is not something that we want. Best regards, Jernej > > Maxime > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel