From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30BE8C52D7F for ; Fri, 16 Aug 2024 00:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:Cc:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iL3g7hzaLQ+rrYtLHSAvIW1379wSOIx3YsifSBddCrY=; b=4bu4CH8I8zr3+2SONlOa0m5AOc lUYw8Ya0Vz14u4JQtcOovypPKDMB1ogGioryIlUMUY9KaXpzfLnZKMz9kXjhNZ3O4NQrty2cw+0qd SA4UlPVgybM1TV6XBhEHIBiM8hbTcbx5XeIDTdnlbIt6cnTeWwqC8yYaoHq8tP215xI4/N0sNTrtL N65KgcKAjijHFRqhuryCwUKcGGxc3NyedFymFle036JkAarkXVChiVFLK9syMw7XlzA/sEGiuGZr0 DaaJp7UyYfo6sLbc609wJFAk5sLZ82r/uG5rMC20e+l3Ob276jSDdIZCx1g1eps5BNOKEh7oqlrhw TgkfOwFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sel5H-0000000BPQl-0jsJ; Fri, 16 Aug 2024 00:44:51 +0000 Received: from mail-m21471.qiye.163.com ([117.135.214.71]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sel4c-0000000BPMW-03pK; Fri, 16 Aug 2024 00:44:12 +0000 DKIM-Signature: a=rsa-sha256; b=J1UE/ruNV7QGyM0y41B5pMuLmVchxWYjJmDqZINeHWDXSansizu6IXSpjUkqLTeg0zS80Lun+gWCHGetcKil7Fke8S4LBE+E9/7vJnGaLhogGWazpVCLFnj7bym4QBZTzXHPIc/4FgWcBAQluFsWtl6xSPjbmdHvK2V2bcaruyA=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=iL3g7hzaLQ+rrYtLHSAvIW1379wSOIx3YsifSBddCrY=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.45] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTPA id E30FD4601FE; Fri, 16 Aug 2024 08:43:48 +0800 (CST) Message-ID: <2517e284-88d0-4cf3-97cf-55567f35eb82@rock-chips.com> Date: Fri, 16 Aug 2024 08:43:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: shawn.lin@rock-chips.com, Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Jaehoon Chung , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v3 2/3] mmc: dw_mmc-rockchip: Add v2 tuning support To: Detlev Casanova , linux-kernel@vger.kernel.org References: <20240814223555.3695-1-detlev.casanova@collabora.com> <20240814223555.3695-3-detlev.casanova@collabora.com> <5dc82aa2-82a0-4778-b598-88775d5f791c@rock-chips.com> <2742918.mvXUDI8C0e@trenzalore> Content-Language: en-GB From: Shawn Lin In-Reply-To: <2742918.mvXUDI8C0e@trenzalore> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQkNMSVZPShlLSx5OGUMaTx9WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhCSE JVSktLVUpCS0tZBg++ X-HM-Tid: 0a9158a4051103aekunme30fd4601fe X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6KyI6OTo6CDIrSzoCNiktTFY# MVEKFA9VSlVKTElITE1CS0hLSENIVTMWGhIXVQgTGgwVVRcSFTsJFBgQVhgTEgsIVRgUFkVZV1kS C1lBWU5DVUlJVUxVSkpPWVdZCAFZQUhCSE43Bg++ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_174410_336271_14FDD3A1 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 在 2024/8/15 21:23, Detlev Casanova 写道: > On Wednesday, 14 August 2024 20:55:37 EDT Shawn Lin wrote: >> Hi Detlev >> >> 在 2024/8/15 6:34, Detlev Casanova 写道: >>> From: Shawn Lin >>> >>> v2 tuning will inherit pre-stage loader's phase settings for the first >>> time, and do re-tune if necessary. >>> Re-tune will still try the rough degrees, for instance, 90, 180, 270, >>> 360 but continue to do the fine tuning if sample window isn't good >>> enough. >>> >>> Signed-off-by: Shawn Lin >>> Signed-off-by: Detlev Casanova >>> --- >>> >>> drivers/mmc/host/dw_mmc-rockchip.c | 49 ++++++++++++++++++++++++++++++ >>> 1 file changed, 49 insertions(+) >>> >>> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c >>> b/drivers/mmc/host/dw_mmc-rockchip.c index b07190ba4b7ac..367633f4e8892 >>> 100644 >>> --- a/drivers/mmc/host/dw_mmc-rockchip.c >>> +++ b/drivers/mmc/host/dw_mmc-rockchip.c > > [...] > >>> >>> priv->default_sample_phase = 0; >>> >>> + priv->use_v2_tuning = >>> + of_device_is_compatible(host->dev->of_node, >>> + "rockchip,rk3576-dw- > mshc"); >>> + >> >> v2 is a kind of software decision instead of hardware dependency. >> So in theory, any SoC can claim to use it via DT. > > Yes but from my tests, only rk3576 won't work without it. So it makes sense to > only use v2 for this SoC (and other future ones not supported yet) > However from both of the IC design POV and the test from my side, we just need internal phase support patch, and rk3576 could work. >> >>> priv->drv_clk = devm_clk_get(host->dev, "ciu-drive"); >>> if (IS_ERR(priv->drv_clk)) >>> >>> dev_dbg(host->dev, "ciu-drive not available\n"); > > > Detlev. > >