From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E235DC5DF97 for ; Wed, 26 Aug 2026 16:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9aTlTrAcUgjj4hArEoKoTq6w3fM8/pT6nYXJB7j/pgw=; b=wvEz3Wl08BCix4izb+/0kke7wX LXw7lJ0CPRRV2RldvhJ/P45TD4Vhiq5Ap2//rv9XE6tBDBpAbJMB30jSTxqG0Fd/FilcYws28p5In QMEkzZeVrXyqTQs3YC7b/sjNPFxUZiDMT0EdkPdHbTmOm99ZZnMdZZF1u33+BzsKTM/aG3JtUBVmd SLoQXhX+8sXwmVF9hQ0lV4Al+a+kjAzas7hrQX3Pg7a8kcy9N/O28hgljSGU+vpZzu2D0CbLXt1ka +76pY2zF7EChxpa5KgzTCXX1d8DAcIszpK+gzs/k2pW6776nIbJ0DVAwHiwngvJnnySRRghThTSTh Br+D5EMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzGpx-00000002mDD-0GqZ; Wed, 26 Aug 2026 16:50:53 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzGpu-00000002mCT-2Vol; Wed, 26 Aug 2026 16:50:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9aTlTrAcUgjj4hArEoKoTq6w3fM8/pT6nYXJB7j/pgw=; b=E04OWKcAdDOgNDJui/H80dCuBh YhIoevjc504XTOm2Vuj2a+wFt8AJ13fsca/VQ9N4Q23f14ScvB9noVZrb8A4nq3pKTXmKWo1CrhbJ SV4tF7XcHM9v3lbkJ6IkecOfjn+gnscIDKHa8aHSkqNFw8SyvkladDBdF+jGUba32blc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wzGpT-001Xv5-Fy; Wed, 26 Aug 2026 18:50:23 +0200 Date: Wed, 26 Aug 2026 18:50:23 +0200 From: Andrew Lunn To: Caleb James DeLisle Cc: ansuelsmth@gmail.com, netdev@vger.kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, daniel@makrotopia.org, dqfext@gmail.com, SkyLake.Huang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 3/3] net: phy: mediatek: support EcoNet EN751221 gbit SoC PHY Message-ID: <25195db9-c15e-449d-b792-8f5a7c0aa371@lunn.ch> References: <20260825193456.1823985-1-cjd@cjdns.fr> <20260825193456.1823985-4-cjd@cjdns.fr> <4d594c62-2ceb-43c1-a3d2-731b80493787@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260826_095050_638722_D9BE876A X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > I tested my board removing the EEE disable and the MASTER line, and it seems > to work. I can't get any CRC errors flooding the link, and MII_STAT1000 > reads LPA_1000LOCALRXOK | LPA_1000REMRXOK | LPA_1000FULL which suggests to > me that it's able to operate happily in slave mode. > > > So unless you or someone else thinks it's inadvisable, I'm inclined to just > enable these things and then wait to see if anybody finds a board that has > problems. Master/slave should sort itself out, maybe taking a little longer if there is an initial conflict. Where it can go wrong is when the random number generator in the PHY always returns 42. Put the same PHY on the other end and the election always fails. EEE issues can be more subtle, it depends on what the link partner is. But yes, we can start without these. But please mention this in the commit message, just to give a hint to anybody who ends up trying to debug in these areas. Andrew