From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
Patrick Wildt <patrick@blueri.se>,
Niklas Cassel <cassel@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
robin.murphy@arm.com
Subject: Re: [PATCH] arm64: dts: rockchip: adjust SMMU interrupt type
Date: Tue, 11 Feb 2025 08:40:25 +0100 [thread overview]
Message-ID: <25203566.ouqheUzb2q@diego> (raw)
In-Reply-To: <Z6pxme2Chmf3d3uK@windev.fritz.box>
Am Montag, 10. Februar 2025, 22:37:29 MEZ schrieb Patrick Wildt:
> The SMMU architecture requires wired interrupts to be edge triggered,
> which does not align with the DT description for the RK3588. This leads
> to interrupt storms, as the SMMU continues to hold the pin high and only
> pulls it down for a short amount when issuing an IRQ. Update the DT
> description to be in line with the spec and perceived reality.
>
Cc'ed Niklas
This should probably also get a
Fixes: cd81d3a0695c ("arm64: dts: rockchip: add rk3588 pcie and php IOMMUs")
> Signed-off-by: Patrick Wildt <patrick@blueri.se>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 8cfa30837ce7..520d0814a4de 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -549,10 +549,10 @@ usb_host2_xhci: usb@fcd00000 {
> mmu600_pcie: iommu@fc900000 {
> compatible = "arm,smmu-v3";
> reg = <0x0 0xfc900000 0x0 0x200000>;
> - interrupts = <GIC_SPI 369 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 367 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupts = <GIC_SPI 369 IRQ_TYPE_EDGE_RISING 0>,
> + <GIC_SPI 371 IRQ_TYPE_EDGE_RISING 0>,
> + <GIC_SPI 374 IRQ_TYPE_EDGE_RISING 0>,
> + <GIC_SPI 367 IRQ_TYPE_EDGE_RISING 0>;
> interrupt-names = "eventq", "gerror", "priq", "cmdq-sync";
> #iommu-cells = <1>;
> };
> @@ -560,10 +560,10 @@ mmu600_pcie: iommu@fc900000 {
> mmu600_php: iommu@fcb00000 {
> compatible = "arm,smmu-v3";
> reg = <0x0 0xfcb00000 0x0 0x200000>;
> - interrupts = <GIC_SPI 381 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 383 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 386 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupts = <GIC_SPI 381 IRQ_TYPE_EDGE_RISING 0>,
> + <GIC_SPI 383 IRQ_TYPE_EDGE_RISING 0>,
> + <GIC_SPI 386 IRQ_TYPE_EDGE_RISING 0>,
> + <GIC_SPI 379 IRQ_TYPE_EDGE_RISING 0>;
> interrupt-names = "eventq", "gerror", "priq", "cmdq-sync";
> #iommu-cells = <1>;
> status = "disabled";
>
next prev parent reply other threads:[~2025-02-11 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 21:37 [PATCH] arm64: dts: rockchip: adjust SMMU interrupt type Patrick Wildt
2025-02-11 7:40 ` Heiko Stübner [this message]
2025-02-11 12:22 ` Niklas Cassel
2025-02-11 18:17 ` Robin Murphy
2025-02-11 20:35 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25203566.ouqheUzb2q@diego \
--to=heiko@sntech.de \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=patrick@blueri.se \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).