From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: mt8173: Add afe device node
Date: Tue, 07 Jul 2015 09:46:55 +0200 [thread overview]
Message-ID: <25205102.t939MQMDBD@ubix> (raw)
In-Reply-To: <CAGS+omCOzJs=VWboU_7doUum6BEfmh1hV88HmJiin2c-A_n_Mw@mail.gmail.com>
On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote:
> On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen <koro.chen@mediatek.com> wrote:
> > This adds afe (audio front end) device node to the MT8173 dtsi file.
> >
> > This patch is based on Matthias's tree:
> > https://github.com/mbgg/linux-mediatek
> > branch: v4.2-next/arm64
> >
> > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
> > ---
> >
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32
> > ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 0696f8f..f8afab4 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -14,6 +14,7 @@
> >
> > #include <dt-bindings/clock/mt8173-clk.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> >
> > +#include <dt-bindings/power/mt8173-power.h>
> >
> > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > #include "mt8173-pinfunc.h"
> >
> > @@ -393,6 +394,37 @@
> >
> > #size-cells = <0>;
> > status = "disabled";
> >
> > };
> >
> > +
> > + afe: mt8173-afe-pcm at 11220000 {
>
> I believe this should be something generic, like:
>
> afe: audio-controller at 11220000
>
Yes, please find a name that better describes the component instead of just
using the compatible string.
Thanks.
next prev parent reply other threads:[~2015-07-07 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 6:52 [PATCH] arm64: dts: mt8173: Add afe device node Koro Chen
2015-07-06 13:02 ` Daniel Kurtz
2015-07-07 7:46 ` Matthias Brugger [this message]
2015-07-07 9:20 ` Koro Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25205102.t939MQMDBD@ubix \
--to=matthias.bgg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox