public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP
Date: Mon, 08 Feb 2016 13:20:40 +0100	[thread overview]
Message-ID: <2530828.WgKqLzsO0l@wuerfel> (raw)
In-Reply-To: <1454922699-16785-3-git-send-email-antoine.tenart@free-electrons.com>

On Monday 08 February 2016 10:11:38 Antoine Tenart wrote:
> index 000000000000..3e3080fa45e4
> --- /dev/null
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> +	model = "Annapurna Labs Alpine v2";
> +	compatible = "al,alpine-v2";
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +		serial3 = &uart3;
> +	};

Move the aliases to the .dts files and drop the ones that are disabled.

> +
> +		pcie-internal at 0xfbc00000 {

make this

		pci at fbc00000 {

> +			compatible = "pci-host-ecam-generic";
> +			device_type = "pci";
> +			#size-cells = <2>;
> +			#address-cells = <3>;
> +			#interrupt-cells = <1>;
> +			reg = <0x0 0xfbc00000 0x0 0x100000>;
> +			interrupt-map-mask = <0xf800 0 0 7>;
> +			/* add legacy interrupts for SATA only */
> +			interrupt-map = <0x4000 0 0 1 &gic 0 53 4>,
> +					<0x4800 0 0 1 &gic 0 54 4>;

What's wrong with the other IRQs? Not connected?

> +
> +		uart0: uart at fd883000 {

			serial at fd883000


Almost all devices are in the 0xfd000000 range. Could this be a bus in the
SoC that has all the devices attached to it? Maybe use a "ranges" property
to reflect that. In doubt, use the register numbers from the data sheet if you
have one.

	Arnd

  parent reply	other threads:[~2016-02-08 12:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08  9:11 [PATCH 0/3] arm64: introduce the Alpine support Antoine Tenart
2016-02-08  9:11 ` [PATCH 1/3] arm64: add Alpine SoC family Antoine Tenart
2016-02-08  9:11 ` [PATCH 2/3] arm64: dts: add the Alpine v2 EVP Antoine Tenart
2016-02-08 10:51   ` Mark Rutland
2016-02-08 11:00     ` Antoine Tenart
2016-02-08 12:20   ` Arnd Bergmann [this message]
2016-02-09 10:18     ` Antoine Tenart
2016-02-08 15:29   ` Marc Zyngier
2016-02-09  8:56     ` Antoine Tenart
2016-02-09  9:01       ` Antoine Tenart
2016-02-09  9:09         ` Marc Zyngier
     [not found]           ` <CABM=7knaepbyy4nw_GczVM7E_t6py7gG0ERs8ru_AYoVXvAQ+A@mail.gmail.com>
2016-02-09  9:30             ` Marc Zyngier
2016-02-09 10:13               ` Tsahee Zidenberg
2016-02-09 10:42                 ` Marc Zyngier
2016-02-09 11:48                 ` Marc Zyngier
2016-02-09 13:54                   ` Tsahee Zidenberg
2016-02-08  9:11 ` [PATCH 3/3] arm64: defconfig: enable the Alpine family Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2530828.WgKqLzsO0l@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox