Re: [PATCH v4 2/3] ARM: dts: rockchip: add rga node for rk322x

Heiko Stuebner
2020-04-18T10:53:49Z

Am Samstag, 18. April 2020, 11:56:03 CEST schrieb Justin Swartz:
> Hi Johan, Heiko,
>
> On 2020-04-18 11:49, Heiko Stuebner wrote:
>
> > Am Samstag, 18. April 2020, 11:15:27 CEST schrieb Johan Jonker:
> >
> >> Hi Justin, Heiko,
> >>
> >> In the discussion about "rockchip,px30-rga" it was mentioned that:
> >> "no status for soc internal components without any board-specifics".
> >> The binding is in mainline, but the dts node is missing I think.
> >> Should this also be changed?
> >
> > yep, drop the status disabled from the dtsi and that then results
> > in not needing the board-level enablement
> >
> > (background: rga is a simple mem2mem device without any
> > board-specific hooks)
>
> Shall I submit version 5 of this patch series?

I guess so ... especially as we expect patch1 to go through the
media tree and sending a new version might serve as a ping :-)
and include the Ack by Rob for easy applying

Heiko

>
> > Johan
> >
> > +&rga {
> > + status = "okay";
> > +};
> > +
> >
> > Add a node to define the presence of RGA, a 2D raster
> > graphic acceleration unit.
> >
> > Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> > ---
> > arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rk322x.dtsi
> > b/arch/arm/boot/dts/rk322x.dtsi
> > index 340ed6ccb..29d50bebc 100644
> > --- a/arch/arm/boot/dts/rk322x.dtsi
> > +++ b/arch/arm/boot/dts/rk322x.dtsi
> > @@ -621,6 +621,17 @@
> > status = "disabled";
> > };
> >
> > + rga: rga@20060000 {
> > + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
> > + reg = <0x20060000 0x1000>;
> > + interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
> > + clock-names = "aclk", "hclk", "sclk";
> > + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru
> > SRST_RGA_H>;
> > + reset-names = "core", "axi", "ahb";
> > + status = "disabled";
> > remove?
> >
> > + };
> > +
> > iep_mmu: iommu@20070800 {
> > compatible = "rockchip,iommu";
> > reg = <0x20070800 0x100>;