From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292E4C433DF for ; Mon, 18 May 2020 22:30:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E91A0207ED for ; Mon, 18 May 2020 22:30:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DBxwrT+V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E91A0207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eTgz1Yuo82p2rca/uRAeQ2KZkPMkhRu2lCaZkNat7eY=; b=DBxwrT+VNuDo3J caScrHi+6UQ3sQ8241ysBse61+CmRwx1N7HYey4xSpwhiT86y6so8DmwCyWr1LrR/pr1R8A1nHpBC Sm0sCyqxFfBSqqvYWQuI+2nLmCi/uht4slRJSALooPJG6Ai8qOE8zMgBOrN6Z59ecvX73K84vdygb 2Y46oebGjbExMPm1aQrDRg0lc0ZOyUxR8pegkRUAPfEMDdMnekD2+jR91gEs34zz/QqMlvLunbIKZ j/7SLBZqL5JtggkZmVco/mb4hjKA9XansQHJusaQDWFm+h3ircbn5EYCN6fMnK1EsfnFZBbuP0FJ0 IjjKkoj1ZWhrbFiwSuBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaoHb-0004nb-FE; Mon, 18 May 2020 22:30:51 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaoG2-0000vg-3D; Mon, 18 May 2020 22:29:16 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaoG0-000081-Ec; Tue, 19 May 2020 00:29:12 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Johan Jonker Subject: Re: [PATCH v3 3/4] arm64: dts: rockchip: remove include for irq.h Date: Tue, 19 May 2020 00:29:11 +0200 Message-ID: <2542759.BOPbJzt3gv@diego> In-Reply-To: <20200403180159.13387-3-jbx6244@gmail.com> References: <20200403180159.13387-1-jbx6244@gmail.com> <20200403180159.13387-3-jbx6244@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_152914_380805_A89E5311 X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Johan, Am Freitag, 3. April 2020, 20:01:58 CEST schrieb Johan Jonker: > The 'irq.h' file is already included through 'arm-gic.h', > so remove them from all Rockchip dtsi files. I disagree here ... we do use properties from both arm-gic.h and the main irq.h an therefore should not rely on the arm-gic.h "accidentially" including irq.h Heiko > Signed-off-by: Johan Jonker > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 1 - > arch/arm64/boot/dts/rockchip/rk3308.dtsi | 1 - > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 - > arch/arm64/boot/dts/rockchip/rk3368.dtsi | 1 - > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index 6f7171290..4820edc7f 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -6,7 +6,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi > index ac43bc3f7..a9b98555d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi > @@ -7,7 +7,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > index 470783a48..175060695 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -6,7 +6,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi > index 1ebb0eef4..f22475016 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi > @@ -5,7 +5,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 0d895cff5..123b7402a 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -6,7 +6,6 @@ > #include > #include > #include > -#include > #include > #include > #include > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel