linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar
@ 2024-03-27 11:21 Heiko Stuebner
  2024-03-27 11:21 ` [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger Heiko Stuebner
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Heiko Stuebner @ 2024-03-27 11:21 UTC (permalink / raw)
  To: heiko; +Cc: linux-arm-kernel, linux-rockchip, quentin.schulz, Heiko Stuebner

From: Heiko Stuebner <heiko.stuebner@cherry.de>

Enable the mali gpu node and add the board-specific supply-regulator.

Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
---
 arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts
index b564c7494878..d422bab41b82 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts
@@ -253,6 +253,11 @@ mdot2e-w-disable2-n-hog {
 	};
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu_s0>;
+	status = "okay";
+};
+
 &i2c0 {
 	pinctrl-0 = <&i2c0m2_xfer>;
 	status = "okay";
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger
  2024-03-27 11:21 [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Heiko Stuebner
@ 2024-03-27 11:21 ` Heiko Stuebner
  2024-03-27 12:31   ` Quentin Schulz
  2024-03-27 12:31 ` [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Quentin Schulz
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Heiko Stuebner @ 2024-03-27 11:21 UTC (permalink / raw)
  To: heiko; +Cc: linux-arm-kernel, linux-rockchip, quentin.schulz, Heiko Stuebner

From: Heiko Stuebner <heiko.stuebner@cherry.de>

Enable the mali gpu node and add the som-specific supply-regulator.

Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
---
 arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
index 6417c24f2e8e..78f5bbddabba 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
@@ -155,6 +155,11 @@ &eth0_pins
 	snps,reset-delays-us = <0 10000 100000>;
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu_s0>;
+	status = "okay";
+};
+
 &i2c1 {
 	pinctrl-0 = <&i2c1m0_xfer>;
 };
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar
  2024-03-27 11:21 [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Heiko Stuebner
  2024-03-27 11:21 ` [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger Heiko Stuebner
@ 2024-03-27 12:31 ` Quentin Schulz
  2024-03-27 13:33 ` Heiko Stuebner
  2024-03-27 15:41 ` Rob Herring
  3 siblings, 0 replies; 7+ messages in thread
From: Quentin Schulz @ 2024-03-27 12:31 UTC (permalink / raw)
  To: Heiko Stuebner; +Cc: linux-arm-kernel, linux-rockchip, Heiko Stuebner

Hi Heiko,

On 3/27/24 12:21, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Enable the mali gpu node and add the board-specific supply-regulator.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>

Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Thanks,
Quentin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger
  2024-03-27 11:21 ` [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger Heiko Stuebner
@ 2024-03-27 12:31   ` Quentin Schulz
  0 siblings, 0 replies; 7+ messages in thread
From: Quentin Schulz @ 2024-03-27 12:31 UTC (permalink / raw)
  To: Heiko Stuebner; +Cc: linux-arm-kernel, linux-rockchip, Heiko Stuebner

Hi Heiko,

On 3/27/24 12:21, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Enable the mali gpu node and add the som-specific supply-regulator.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>

Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Thanks,
Quentin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar
  2024-03-27 11:21 [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Heiko Stuebner
  2024-03-27 11:21 ` [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger Heiko Stuebner
  2024-03-27 12:31 ` [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Quentin Schulz
@ 2024-03-27 13:33 ` Heiko Stuebner
  2024-03-27 15:41 ` Rob Herring
  3 siblings, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2024-03-27 13:33 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: quentin.schulz, Heiko Stuebner, linux-rockchip, linux-arm-kernel

On Wed, 27 Mar 2024 12:21:19 +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Enable the mali gpu node and add the board-specific supply-regulator.
> 
> 

Applied, thanks!

[1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar
      commit: 51ca6a22c52b10a787fa3fad2343279f11da27bb
[2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger
      commit: f5256f8ed4b729c3ab9d9cd7d406313773484b59

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar
  2024-03-27 11:21 [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Heiko Stuebner
                   ` (2 preceding siblings ...)
  2024-03-27 13:33 ` Heiko Stuebner
@ 2024-03-27 15:41 ` Rob Herring
  2024-03-27 20:30   ` Heiko Stübner
  3 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2024-03-27 15:41 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Heiko Stuebner, linux-rockchip, quentin.schulz, linux-arm-kernel


On Wed, 27 Mar 2024 12:21:19 +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Enable the mali gpu node and add the board-specific supply-regulator.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3588-jaguar.dtb' for 20240327112120.1181570-1-heiko@sntech.de:

Error: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts:248.1-5 Label or path gpu not found
FATAL ERROR: Syntax error parsing input tree
make[3]: *** [scripts/Makefile.lib:427: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb] Error 1
make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2
make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1387: rockchip/rk3588-jaguar.dtb] Error 2
make: *** [Makefile:240: __sub-make] Error 2
make: Target 'rockchip/rk3588-jaguar.dtb' not remade because of errors.






_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar
  2024-03-27 15:41 ` Rob Herring
@ 2024-03-27 20:30   ` Heiko Stübner
  0 siblings, 0 replies; 7+ messages in thread
From: Heiko Stübner @ 2024-03-27 20:30 UTC (permalink / raw)
  To: Rob Herring
  Cc: Heiko Stuebner, linux-rockchip, quentin.schulz, linux-arm-kernel

Am Mittwoch, 27. März 2024, 16:41:16 CET schrieb Rob Herring:
> 
> On Wed, 27 Mar 2024 12:21:19 +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@cherry.de>
> > 
> > Enable the mali gpu node and add the board-specific supply-regulator.
> > 
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y rockchip/rk3588-jaguar.dtb' for 20240327112120.1181570-1-heiko@sntech.de:
> 
> Error: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts:248.1-5 Label or path gpu not found
> FATAL ERROR: Syntax error parsing input tree
> make[3]: *** [scripts/Makefile.lib:427: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb] Error 1
> make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2
> make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb' not remade because of errors.
> make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1387: rockchip/rk3588-jaguar.dtb] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
> make: Target 'rockchip/rk3588-jaguar.dtb' not remade because of errors.

just for the record, that error fixes itself because the patch gets applied only after
the main series adding that gpu node ;-)


Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-03-27 20:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-27 11:21 [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Heiko Stuebner
2024-03-27 11:21 ` [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger Heiko Stuebner
2024-03-27 12:31   ` Quentin Schulz
2024-03-27 12:31 ` [PATCH 1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar Quentin Schulz
2024-03-27 13:33 ` Heiko Stuebner
2024-03-27 15:41 ` Rob Herring
2024-03-27 20:30   ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).