From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v5 1/2] dt-bindings: extcon-usb-gpio: convert to DT schema format
Date: Fri, 28 Jun 2024 11:14:49 +0200 [thread overview]
Message-ID: <2550039.Sgy9Pd6rRy@steina-w> (raw)
In-Reply-To: <20240215093214.796821-2-alexander.stein@ew.tq-group.com>
Am Donnerstag, 15. Februar 2024, 10:32:13 CEST schrieb Alexander Stein:
> Convert the binding to DT schema format. Change the GPIO properties to new
> naming convention using -gpios as well.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Patch 2 has been applied as 5b6df373ec95cf051264f655be0dbe1d6caa173c
Who is going to pick this?
Thanks
Alexander
> ---
> .../bindings/extcon/extcon-usb-gpio.txt | 21 --------
> .../bindings/extcon/extcon-usb-gpio.yaml | 51 +++++++++++++++++++
> 2 files changed, 51 insertions(+), 21 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> deleted file mode 100644
> index dfc14f71e81fb..0000000000000
> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -USB GPIO Extcon device
> -
> -This is a virtual device used to generate USB cable states from the USB ID pin
> -connected to a GPIO pin.
> -
> -Required properties:
> -- compatible: Should be "linux,extcon-usb-gpio"
> -
> -Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
> -- id-gpio: gpio for USB ID pin. See gpio binding.
> -- vbus-gpio: gpio for USB VBUS pin.
> -
> -Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
> - extcon_usb1 {
> - compatible = "linux,extcon-usb-gpio";
> - id-gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>;
> - }
> -
> - &omap_dwc3_1 {
> - extcon = <&extcon_usb1>;
> - };
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
> new file mode 100644
> index 0000000000000..136f865b87816
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/extcon/extcon-usb-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: USB GPIO Extcon device
> +
> +maintainers:
> + - Alexander Stein <alexander.stein@ew.tq-group.com>
> +
> +description:
> + This is a virtual device used to generate USB cable states from the
> + USB ID pin connected to a GPIO pin.
> + Deprecated, use USB connector node instead.
> +
> +deprecated: true
> +
> +properties:
> + compatible:
> + const: linux,extcon-usb-gpio
> +
> + id-gpios:
> + description: An input gpio for USB ID pin.
> + maxItems: 1
> +
> + vbus-gpios:
> + description: An input gpio for USB VBus pin, used to detect presence of
> + VBUS 5V.
> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +anyOf:
> + - required:
> + - id-gpios
> + - required:
> + - vbus-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + extcon-usb1 {
> + compatible = "linux,extcon-usb-gpio";
> + id-gpios = <&gpio6 1 GPIO_ACTIVE_HIGH>;
> + vbus-gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;
> + };
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2024-06-28 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 9:32 [PATCH v5 0/2] extcon-usb-gpio YAML conversion Alexander Stein
2024-02-15 9:32 ` [PATCH v5 1/2] dt-bindings: extcon-usb-gpio: convert to DT schema format Alexander Stein
2024-06-28 9:14 ` Alexander Stein [this message]
2024-02-15 9:32 ` [PATCH v5 2/2] arm64: dts: mediatek: Replace deprecated extcon-usb-gpio id-gpio/vbus-gpio properties Alexander Stein
2024-02-15 11:09 ` (subset) [PATCH v5 0/2] extcon-usb-gpio YAML conversion AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2550039.Sgy9Pd6rRy@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox